From nobody Sat May 10 10:13:40 2025 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZvhXm181Pz5wB3K; Sat, 10 May 2025 10:13:44 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZvhXm0Y2kz3KgM; Sat, 10 May 2025 10:13:44 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746872024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KmnNyrw5XVSi9vmoxvr2fpVo/+1KJR5TwTIAvFHlc9k=; b=HxWIrn9WK+n8s7MS5EcN+BcD7u64CQs9pto8bv/vfEWXZcTRwZA5Fx6XVA1wdy/IvzeZe8 e+Mq3aravuTp/c2qtmWua4V+5wnoD5qHauSo5rkB0WDDR8go34VmN2r72UsLcmTUmqoIPS nQgaO0EIan1bIr/lWNkY76ss9wLmXgiQ80fYJb6azVR+K3I9YJ/9HzzPCDax0+ul0YePjz fpvzq+ASZEc1jjCWXVv4kRRU11MFc1/8rNihAFangO2PmmhoYiVbWGKmg1xFWP6l9YWcxJ ydzxjoettzHIu+vmNK9XfDajRQod8qM0Ld3cgMyxwnHoWRp3rmr720N53bOAXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746872024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KmnNyrw5XVSi9vmoxvr2fpVo/+1KJR5TwTIAvFHlc9k=; b=XPsabtaTRRsX8cg3fFwKb0sp5O2wlUityDbPKULVY+aXRpreI09iZDDuNE9YQmNV4DJZwZ QuOI28uiu3Eg1wQ0C8cwmq+yvIMqCPFHxF++tWGYPTd+Ej4GZb5ef0Vmvfgk1uWU3o0TKu PjJVtNTSAQfHIHI9+jg1r9dZbHRAB0bkRA7K+xWIYE3e8t2PdpJ2EqdabKw/ORuFYxylcg dKj1iFtGUSgc4/8Thfwz3J9U52CK5FkxskEtpjQtvvT6tutyTiMQPjPCDkS1Ys5JTCwNCB JtjuwaChVBKq3OMWcoWe8hVItwO1Ms0qE3TeHEGHlQllFXBZkH2NjYBBHlMXAg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1746872024; a=rsa-sha256; cv=none; b=FMSp8n7Ohf3ayRYnIIJEOkw14JWw5bJTNOTDAiidrRRWOVqDUzGa3LmPmebrn32Cziw6UM JntOm1UoibBv5AF/Z8FnbaYs9Y9AXw0pTdxEEFFcQ9vlzgek7bo4APG4j5Oclnu1lycs9j vbV5nPXYoIB/EQ/pQiKyzuoQqmEjMdVFkt6loiyhQBFWdP2aBBhvJyPLGujISnqnMbIwrm LQ/4xzPmVQ+82qdya04Qwy7yb2EpN1eUqcn6z92m9j1Owj/fy+qBZNKrByy0vrf6CGuQWH pdaNH9ArEruev2/TI4t14WkCSOlfAQS1EZqSIYBwReJOEIJ+p82nD3MlyM4i2g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: by freefall.freebsd.org (Postfix, from userid 1033) id EA55C2308; Sat, 10 May 2025 10:13:40 +0000 (UTC) Date: Sat, 10 May 2025 10:13:40 +0000 From: Alexey Dokuchaev To: Gleb Popov Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 1a8a9a832eb5 - main - devel/libvirt: depend on GNU grep(1) in a more robust way Message-ID: References: <202505100936.54A9a5nP034105@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, May 10, 2025 at 12:48:31PM +0300, Gleb Popov wrote: > On Sat, May 10, 2025 at 12:36???PM Alexey Dokuchaev wrote: > > commit 1a8a9a832eb52cb3bb7ea6453a88451d54ebc597 > > > > devel/libvirt: depend on GNU grep(1) in a more robust way > > > > FreeBSD ships native grep(1) implementation in the base for > > quite a while, so don't bother to check its origin and just > > request GNU version explicitly like on Darwin (macOS). > > > > Depending on `/usr/local/bin/grep' is also wrong because of > > the hardcoded prefix and because compatibility symlinks are > > optional (plans are to disable them in the future). > > This change doesn't make sense to me. Can you please elaborate > on the last paragraph? Ports could be installed into prefix other than `/usr/local', yet the path is hardcoded in the `build-aux/meson.build', meaning it's likely to break with custom-PREFIX'ed packages. While not very common, we support this and IIRC there were occasional exp-runs in the past for custom values of PREFIX/LOCALBASE (with lots of fallout as one might expect). However, more importantly is that `bin/grep' is guarded by the COMPAT option, hence it is not guaranteed to exist even under `/usr/local', while `bin/ggrep' is always there, similar to other GNU tools which are typically configured with `--program-prefix=g'. People had been asking me to stop installing those compatibility symlinks by default, so one day I might make the option opt-in rather than opt-out. HTH, ./danfe