Re: git: 62b50f7bd59a - main - x11-toolkits/py-tkinter: remove Python 2 support

From: Craig Leres <leres_at_freebsd.org>
Date: Mon, 10 Mar 2025 20:14:03 UTC 
On 3/10/25 12:29, Charlie Li wrote:
> The branch main has been updated by vishwin:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=62b50f7bd59a6da561894816e2ec0b3352b9208f
> 
> commit 62b50f7bd59a6da561894816e2ec0b3352b9208f
> Author:     Charlie Li <vishwin@FreeBSD.org>
> AuthorDate: 2025-03-10 19:23:54 +0000
> Commit:     Charlie Li <vishwin@FreeBSD.org>
> CommitDate: 2025-03-10 19:28:14 +0000
> 
>      x11-toolkits/py-tkinter: remove Python 2 support
>      
>      No remaining consumers in the tree after re-including _tkinter into
>      lang/python27 itself. This is to prepare for conversion to
>      USE_PYTHON=pep517, as none of such tooling works with Python 2.
>      
>      PR: 268283
> ---
>   x11-toolkits/py-tkinter/Makefile        |  7 ++----
>   x11-toolkits/py-tkinter/files/setup.py  |  9 ++++----
>   x11-toolkits/py-tkinter/files/setup3.py | 40 ---------------------------------
>   3 files changed, 6 insertions(+), 50 deletions(-)
> 
> diff --git a/x11-toolkits/py-tkinter/Makefile b/x11-toolkits/py-tkinter/Makefile
> index f3e2c18fd926..c1d4ad3ca163 100644
> --- a/x11-toolkits/py-tkinter/Makefile
> +++ b/x11-toolkits/py-tkinter/Makefile
[...]
>   DIST_SUBDIR=	python
> @@ -25,10 +25,7 @@ PYDISTUTILS_INSTALLARGS+=	--install-lib ${PYTHON_LIBDIR}/lib-dynload
>   .include <bsd.port.pre.mk>
>   
>   post-extract:
> -.if ${PYTHON_REL} < 30000
>   	@${SED} -e "s|%%TK_VER%%|${TK_VER}|" ${FILESDIR}/setup.py > ${WRKSRC}/setup.py
> -.else
> -	@${SED} -e "s|%%TK_VER%%|${TK_VER}|" ${FILESDIR}/setup3.py > ${WRKSRC}/setup.py
>   .endif

This change breaks building with poudriere for me.

		Craig

[00:00:02] [Dry Run] Gathering ports metadata
[00:00:04] [Dry Run] Warning: (x11-toolkits/py-tkinter): make: 
"/usr/ports/x11-toolkits/py-tkinter/Makefile" line 29: if-less e
ndif
[00:00:04] [Dry Run] Warning: (x11-toolkits/py-tkinter): make: Fatal 
errors encountered -- cannot continue
[00:00:04] [Dry Run] Warning: (x11-toolkits/py-tkinter): Error: Error 
looking up dependencies for x11-toolkits/py-tkinter
[00:00:04] [Dry Run] Error: Fatal errors encountered gathering ports 
metadata