git: eb3f4375632b - main - Mk/Scripts/qa.sh: Fix false positives in LIB_DEPENDS warnings

From: Joseph Mingrone <jrm_at_FreeBSD.org>
Date: Mon, 16 Jun 2025 23:25:22 UTC
The branch main has been updated by jrm:

URL: https://cgit.FreeBSD.org/ports/commit/?id=eb3f4375632b6c6b29280241d62aba0ae6208a54

commit eb3f4375632b6c6b29280241d62aba0ae6208a54
Author:     Joseph Mingrone <jrm@FreeBSD.org>
AuthorDate: 2025-06-14 19:29:27 +0000
Commit:     Joseph Mingrone <jrm@FreeBSD.org>
CommitDate: 2025-06-16 23:24:17 +0000

    Mk/Scripts/qa.sh: Fix false positives in LIB_DEPENDS warnings
    
    To warn when library dependencies may not be required, the proxydeps()
    function compares the libraries listed in LIB_DEPENDS with those
    reported by ldd.  However, the list from ldd is sanitized to remove
    version information from the library names, while the entries from
    LIB_DEPENDS are not.  This leads to comparisons such as libreadline.so.8
    from LIB_DEPENDS versus libreadline.so from ldd, resulting in false
    positives.  Adjust the comparison to avoid such false-positive warnings.
    
    Event:          Kitchener-Waterloo Hackathon 202506
    Reviewed by:    emaste, rene
    Approved by:    portmgr (rene)
    Sponsored by:   The FreeBSD Foundation
    Differential Revision:  https://reviews.freebsd.org/D50860
---
 Mk/Scripts/qa.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Mk/Scripts/qa.sh b/Mk/Scripts/qa.sh
index a0a7aa21d29a..781143db972e 100644
--- a/Mk/Scripts/qa.sh
+++ b/Mk/Scripts/qa.sh
@@ -724,7 +724,7 @@ proxydeps() {
 
 	# Check whether all files in LIB_DEPENDS are actually linked against
 	for _library in ${WANTED_LIBRARIES} ; do
-		if ! listcontains ${_library} "${dep_lib_files}" ; then
+		if ! listcontains ${_library%%.so*}.so "${dep_lib_files}" ; then
 			warn "you might not need LIB_DEPENDS on ${_library}"
 		fi
 	done