Re: git: 11558fb6d8be - main - devel/reposilite: DISTNAME should be PORTNAME

On 2025-06-15 13:22, Jason E. Hale wrote:
> On Sun, Jun 15, 2025 at 4:16 AM Alexey Dokuchaev <danfe@freebsd.org> wrote:
>>
>> On Thu, Jun 12, 2025 at 02:41:52PM +0000, Michael Osipov wrote:
>>> commit 11558fb6d8beddc1c9112d1122dab0850e6681f9
>>>
>>>    devel/reposilite: DISTNAME should be PORTNAME
>>>
>>>    PR:             287473
>>> ...
>>> --- a/devel/reposilite/Makefile
>>> +++ b/devel/reposilite/Makefile
>>> @@ -1,4 +1,4 @@
>>> -DISTNAME=                            reposilite
>>> +PORTNAME=                            reposilite
>>>   DISTVERSION=                         3.5.24
>>>   DISTVERSIONSUFFIX=                   -all
>>>   CATEGORIES=                          devel www java
>>
>> Nice illustration how forcing DISTVERSION instead of PORTVERSION can
>> lead to mistakes like this. :-)
>>
> 
> This was actually suggested by his *mentor* otis@ along with
> unsilencing MKDIR commands [1]. Unbelievable.

Yes, I best otis@ just confused it, but I noticed it too late. I never 
understood why commands have to unsilenced...

>> On an unrelated note, what's with the indentation in that Makefile?
>> Every line should be at least two tabstops shorter (some even worse).
>>
> 
> Strong agree. The indentation is absolutely abhorrent. Seriously, WTF!?

Please change. I can't push directly since I need to go through the 
approval process first.

> [1] https://reviews.freebsd.org/D50802#1159466
> 
> - Jason
> 
>> ./danfe