Re: git: 69d37513cc8c - main - net/pimd: Fix the embedded version number

On 2025-06-08 05:17, Olivier Cochard wrote:
> The branch main has been updated by olivier:
>
> URL:https://cgit.FreeBSD.org/ports/commit/?id=69d37513cc8cd87cd8758d8c30aa32f09be85ad9
>
> commit 69d37513cc8cd87cd8758d8c30aa32f09be85ad9
> Author:     Olivier Cochard<olivier@FreeBSD.org>
> AuthorDate: 2025-06-08 03:11:47 +0000
> Commit:     Olivier Cochard<olivier@FreeBSD.org>
> CommitDate: 2025-06-08 03:15:25 +0000
>
>      net/pimd: Fix the embedded version number
>      
>      Reported by:    diizzy
> ---
>   net/pimd/Makefile                 | 1 +
>   net/pimd/files/patch-configure.ac | 9 +++++++++
>   2 files changed, 10 insertions(+)
>
> diff --git a/net/pimd/Makefile b/net/pimd/Makefile
> index 6f9f24fac619..265943fce2de 100644
> --- a/net/pimd/Makefile
> +++ b/net/pimd/Makefile
> @@ -1,5 +1,6 @@
>   PORTNAME=	pimd
>   PORTVERSION=	2.3.2b
> +PORTREVISION=	1
>   CATEGORIES=	net
>   
>   MAINTAINER=	olivier@FreeBSD.org
> diff --git a/net/pimd/files/patch-configure.ac b/net/pimd/files/patch-configure.ac
> new file mode 100644
> index 000000000000..12d480edfa35
> --- /dev/null
> +++ b/net/pimd/files/patch-configure.ac
> @@ -0,0 +1,9 @@
> +--- configure.ac.orig	2025-06-08 03:07:24 UTC
> ++++ configure.ac
> +@@ -1,5 +1,5 @@ AC_PREREQ(2.61)
> + AC_PREREQ(2.61)
> +-AC_INIT(pimd, 3.0-beta1,https://github.com/troglobit/pimd/issues, ,https://troglobit.com/projects/pimd)
> ++AC_INIT(pimd, 2.3.2b,https://github.com/troglobit/pimd/issues, ,https://troglobit.com/projects/pimd)
> + AC_CONFIG_AUX_DIR(aux)
> + AM_INIT_AUTOMAKE([1.11 foreign])
> + AM_SILENT_RULES([yes])

Hi,

This isn't the appropriate approach, why is versioning rewritten and 
changed from upstream?

Is there a reason to why you're not using USES= autoreconf fully?

You can also shorten the Makefile by using post-install to install the 
additional files rather than overriding do-install completely.

MAKE_ARGS also appears to be unnecessary having a quick look at the logs

Best regards,

Daniel