Re: git: 7abc858c15be - main - devel/kf6-solid: Add patch to revert showing ZFS datasets as devices

In reply to: Max Brazhnikov : "Re: git: 7abc858c15be - main - devel/kf6-solid: Add patch to revert showing ZFS datasets as devices"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Gleb Popov <arrowd_at_freebsd.org>
Date: Tue, 01 Jul 2025 13:45:41 UTC

On Tue, Jul 1, 2025 at 4:04 PM Max Brazhnikov <makc@freebsd.org> wrote:
>
> Folks, I have a couple of issues with this commit.
>
> Firstly, the commit message does not explain the reason for revert. It is not clear for me what is wrong with the zfs check here.
>
> Secondly, I believe we should not add local patches that alter KDE Frameworks behavior and diverge KDE/FreeBSD from vanilla KDE. Especially, considering upstream openness and friendliness to FreeBSD in general.

Yes, here is the explanation for this change that I sent upstream:
https://invent.kde.org/frameworks/solid/-/merge_requests/209#note_1251867