From nobody Tue Jul 01 13:04:55 2025 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bWjtM0gDCz60MpM; Tue, 01 Jul 2025 13:04:59 +0000 (UTC) (envelope-from makc@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bWjtL73xVz4Gds; Tue, 01 Jul 2025 13:04:58 +0000 (UTC) (envelope-from makc@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751375099; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zui6b4ue3cbRk8DK/YNr+a+xEvJFSDHa7JmdIdNxxs8=; b=UzX7jAaz7A/8JHlAL/Ok2Bdcccubb8V3WD+OJaKnMy0NI08OfLzQzHDMzKbxhNDtn1Nj47 XCW48s0Kb8SRZGp1eMrNWz7Iik7h+EcnDDLWIQ3r1gmS1/uV0bMVLEmwjy8BVM0jVJo1tH ptEspgtOGkHbgkqoPjRDGAn+y45R6smRYLWKkZAhmyP7CJwf8lB98g3m53GAHirToVv5B5 RRFBGvvZ678E2s+h18QTiriYBVDCXEBId8LrHaim2FTOuGlcUcX7gWHD7CNmnsodOyA7rf qZa0MM5wGi0DB05nybdZtLrDrW3KIvPcy70M5bF001orGEYEnQQ/+2Tkaf75ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751375099; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zui6b4ue3cbRk8DK/YNr+a+xEvJFSDHa7JmdIdNxxs8=; b=RyRH6zsS7+fuKUnH3xxM0dbXnro/opklgqu74EcOBVfwgERFPP1t+m/xrltbYSM7Hmra22 Q1hf+UDr9Ry8OLrfedW37pSNOTyXHbQI4v346AeVFI7cAELpcsDm1aq/iWHEL7bG6/Wslt 7OtWDxHhnkeJ5bOD7xr1r5SKqZ879CczBtmuOWB9ZrD+TEz7Ve1IGpmFTaJ7HxCJvQOfsC sF9PU/jD+eojkVRI7NSYqpzGHopKIFV+j7TTWhPZWHg8k8hOt6IeYUZCcyx7PtM0kj/98u xZRl+IXordeb/RWCHlgD2yy6Z6RWYrxgELsjbPfSH3BLA1Y4BAPQK09GnRIFXw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751375099; a=rsa-sha256; cv=none; b=XRoO/MLSxeKlJ2707HJEGSBsdJrCwMhfSwoyJatV4hHrlmR4/kUa++rcy04XwvVZ7ATrIX eb4Xx3W/ySuJATq4KI1nagHgXlcgJUP9F0djzk4eDPO+xPjiZ7tsVkNnUp2cW4ebIjCMxm lD9f/pTqt0uLHcZm+xTgttAcdC0u688wymmoQfooswMZh8uIm7unn2i3dCNLxoUxmsQP/n TacVF77K9VU8k2wj1GVaXGJ2xzU4iAxiJSBk5oEfsAHV9W8Yj8CjpVETp9XJhJJBDIwMsY UoM9zi/RrGqzqnG4co71sTAbWBH60BvhDAxOrRU6TVPwK3IiMElsNeOBKcYraA== Received: from mercury.localnet (unknown [62.63.94.159]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: makc) by smtp.freebsd.org (Postfix) with ESMTPSA id 4bWjtL0VW1z1CHx; Tue, 01 Jul 2025 13:04:57 +0000 (UTC) (envelope-from makc@freebsd.org) From: Max Brazhnikov To: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, Gleb Popov , kenrap@kennethraplee.com, kde@freebsd.org Subject: Re: git: 7abc858c15be - main - devel/kf6-solid: Add patch to revert showing ZFS datasets as devices Date: Tue, 01 Jul 2025 16:04:55 +0300 Message-ID: <5979429.8T7jmnknE8@mercury> In-Reply-To: <202506300943.55U9hbGL045657@gitrepo.freebsd.org> References: <202506300943.55U9hbGL045657@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" > URL: https://cgit.FreeBSD.org/ports/commit/?id=7abc858c15be143c75ca55def487ab2634a44280 > > commit 7abc858c15be143c75ca55def487ab2634a44280 > Author: Kenneth Raplee > AuthorDate: 2025-06-30 07:59:53 +0000 > Commit: Gleb Popov > CommitDate: 2025-06-30 09:43:24 +0000 > > devel/kf6-solid: Add patch to revert showing ZFS datasets as devices > > Pull Request: https://github.com/freebsd/freebsd-ports/pull/416 > --- > devel/kf6-solid/Makefile | 1 + > ...tch-src_solid_devices_backends_fstab_fstabhandling.cpp | 15 +++++++++++++++ > 2 files changed, 16 insertions(+) > > diff --git a/devel/kf6-solid/Makefile b/devel/kf6-solid/Makefile > index 4000bd2476ea..169834b0005e 100644 > --- a/devel/kf6-solid/Makefile > +++ b/devel/kf6-solid/Makefile > @@ -1,5 +1,6 @@ > PORTNAME= solid > DISTVERSION= ${KDE_FRAMEWORKS_VERSION} > +PORTREVISION= 1 > CATEGORIES= devel kde kde-frameworks > > COMMENT= Desktop hardware abstraction > diff --git a/devel/kf6-solid/file/patch-src_solid_devices_backends_fstab_fstabhandling.cpp b/devel/kf6-solid/file/patch-src_solid_devices_backends_fstab_fstabhandling.cpp > new file mode 100644 > index 000000000000..8f6498ed4970 > --- /dev/null > +++ b/devel/kf6-solid/file/patch-src_solid_devices_backends_fstab_fstabhandling.cpp > @@ -0,0 +1,15 @@ > +--- src/solid/devices/backends/fstab/fstabhandling.cpp.orig 2025-06-13 09:40:36 UTC > ++++ src/solid/devices/backends/fstab/fstabhandling.cpp > +@@ -70,11 +70,7 @@ bool _k_isFstabSupportedLocalFileSystem(const QString > + if (fstype == QLatin1String("fuse.encfs") // > + || fstype == QLatin1String("fuse.cryfs") // > + || fstype == QLatin1String("fuse.gocryptfs") // > +- || fstype == QLatin1String("overlay") > +- > +- // handle ZFS here as udisk2 doesn't support that yet > +- // see https://github.com/storaged-project/udisks/issues/42 > +- || fstype == QLatin1String("zfs")) { > ++ || fstype == QLatin1String("overlay")) { > + return true; > + } > + return false; Folks, I have a couple of issues with this commit. Firstly, the commit message does not explain the reason for revert. It is not clear for me what is wrong with the zfs check here. Secondly, I believe we should not add local patches that alter KDE Frameworks behavior and diverge KDE/FreeBSD from vanilla KDE. Especially, considering upstream openness and friendliness to FreeBSD in general. Cheers, Max