Re: git: 560772623792 - main - net/freerdp3: adjust missed reference to www/webkit2-gtk

Hi.

> Vladimir Druzenko wrote:
>> 21.01.2025 16:43, Charlie Li пишет:
>>> -WEBKIT_LIB_DEPENDS_=	libsoup-2.4.so:devel/libsoup \
>>> +WEBKIT_LIB_DEPENDS=	libsoup-2.4.so:devel/libsoup \
>> 
>> This is not a typo. Please revert this line back.
>> 
> Is there a reason for the trailing underscore? It causes tooling and 
> regexes that look for *_DEPENDS to miss lines like this, so ports like 
> this get missed when dependencies need their consumers bumped.

Found logics using it in line 216 through line 229 of
net/freerdp3/Makefile as below.

Possibly I'm overlooking something, but something like
"WEBENGINE_USE_GNOME= " are not implemented, while "*_USES=" and
"*_*DEPENDS" are implemented. Vladimir, is this the reason you've used
variable with trailing underscore?

===== Quote =====

.if ${PORT_OPTIONS:MAAD}
.  if ${PORT_OPTIONS:MWEBENGINE}
USES+=		${WEBENGINE_USES_}
USE_QT+=	${WEBENGINE_USE_QT}
.  elif ${PORT_OPTIONS:MWEBKIT}
LIB_DEPENDS+=	${WEBKIT_LIB_DEPENDS_}
USES+=		${WEBKIT_USES_}
USE_GNOME+=	${WEBKIT_USE_GNOME}
.  else
CMAKE_OFF+=	WITH_WEBVIEW
.  endif
.else
CMAKE_OFF+=	WITH_WEBVIEW
.endif

===== End quote =====

Regards.

-- 
Charlie Li
...nope, still don't have an exit line.

-- 
Tomoaki AOKI    <junchoon@dec.sakura.ne.jp>