git: 121fcc3c22e2 - main - devel/icu: Revert hostile 34b444edf6319efbf1ee2c8b75e3e4db1f72378c
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Fri, 28 Feb 2025 10:52:56 UTC
The branch main has been updated by sunpoet:
URL: https://cgit.FreeBSD.org/ports/commit/?id=121fcc3c22e20c70a2bf1ad6281857757c8773e4
commit 121fcc3c22e20c70a2bf1ad6281857757c8773e4
Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2025-02-28 10:35:36 +0000
Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2025-02-28 10:35:36 +0000
devel/icu: Revert hostile 34b444edf6319efbf1ee2c8b75e3e4db1f72378c
It is already part of my patch (attachment 256309 of PR 278420 [1]) which is set maintainer-approval+ [2].
However, it was intentionally ignored when diizzy@ committed 2dd24161c13d36a514a19fe5fea94260400b44de [3].
Comparing to his own patch [4], [1] also fixes PORTREVISION which is committed but missing in his commit log.
Instead, he declared my patch [1] as "mainly style changes".
Reference: https://bugs.freebsd.org/bugzilla/attachment.cgi?id=256309&action=diff [1]
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=278420#c11 [2]
https://cgit.freebsd.org/ports/commit/?id=2dd24161c13d36a514a19fe5fea94260400b44de [3]
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=256097&action=diff [4]
---
devel/icu/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/devel/icu/Makefile b/devel/icu/Makefile
index 911f9bce54cf..e3b4960e7d7a 100644
--- a/devel/icu/Makefile
+++ b/devel/icu/Makefile
@@ -35,7 +35,7 @@ WRKSRC= ${WRKDIR}/icu/source
ICUMAJOR= ${PORTVERSION:C/\..*//}
PLIST_SUB+= ICUMAJOR=${ICUMAJOR} ICUVER=${PORTVERSION:C/r.?/1/}
-.ifndef PKGNAMESUFFIX
+.if !defined(PKGNAMESUFFIX)
post-install:
@${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/g* \
${STAGEDIR}${PREFIX}/bin/*conv \
@@ -47,6 +47,6 @@ post-install:
# Filename varies by endianness: icudt<major>b.dat vs. icudt<major>l.dat
@(cd ${STAGEDIR}${PREFIX} && ${ECHO_CMD} \
${DATADIR_REL}/${PORTVERSION:C/r.?/1/}/icudt*.dat >>${TMPPLIST})
-.endif # PKGNAMESUFFIX
+.endif # !defined(PKGNAMESUFFIX)
.include <bsd.port.mk>