Re: git: 39dbb2a182af - main - devel/abseil: update Abseil C++ to LTS version 20250127.0

From: Alexey Dokuchaev <danfe_at_freebsd.org>
Date: Sun, 23 Feb 2025 11:57:49 UTC
On Sun, Feb 23, 2025 at 06:16:59AM -0500, Jason E. Hale wrote:
> On Sat, Feb 22, 2025 at 11:46???PM Alexey Dokuchaev <danfe@freebsd.org> wrote:
> > commit 39dbb2a182afa2b14b64c1e1b818e6f921817d2d
> >
> >   devel/abseil: update Abseil C++ to LTS version 20250127.0
> >
> >   As of this release, ABSL_PROPAGATE_CXX_STD is enabled by default
> >   so work-arounds like the one in the `devel/libphonenumber' port
> >   are no longer necessary.
> 
> Thanks for remembering libphonenumber! I've wanted to get rid of that
> workaround for a while, but it seems like the CXX_STD isn't being
> propagated in this release. In the previous release of abseil, just
> adding -DABSL_PROPAGATE_CXX_STD:BOOL=ON to CMAKE_ARGS in abseil's
> Makefile worked great,

Yeah, I've put -DABSL_PROPAGATE_CXX_STD:BOOL=ON in the Makefile after
we've discussed that last August, with the intention to commit it on
the next update, but discovered that new version already sets it by
default, hence I've dropped that patch hunk.

> but something fishy is going on now.  libphonenumber still won't build
> without the workaround in this release.

Interesting.  Ping me when you figure this out and if anything needs
to be adjusted in the Abseil port.

./danfe