Re: git: 9c1d7dcbc162 - main - www/dillo2: Add GIF option

On Tue, Feb 18, 2025 at 12:18:23PM -0800, Cy Schubert wrote:
> In message <Z7TivkS9Gvw4vAEf@FreeBSD.org>, Alexey Dokuchaev writes:
> > On Tue, Feb 18, 2025 at 06:31:47PM +0000, Cy Schubert wrote:
> > > commit 9c1d7dcbc16262b2c2f10cb92be102de6a97638d
> > > 
> > >   www/dillo2: Add GIF option
> > > 
> > >   This option was enabled by default by the dillo2 ./configure.
> > >   Add a knob to control this option.
> > > 
> > > [...]
> > >  
> > > +GIF_CONFIGURE_ENABLE=	gif
> > > +
> >
> > Since there's no accompanying LIB_DEPENDS, what's the reason to
> > add an option?  If GIF support comes from the bundled library it
> > should have been mentioned in the commit log, otherwise I see no
> > reason to disable it.
> 
> As far as I can tell there are no libraries removed (from ldd) when
> this default ./configure option is disabled.
> 
> I suppose we can simply remove all the graphics options except for
> WEBP then. That woulod certainly simplify the port.

In general, we make features optional when they entail additional, esp.
heavy dependencies.  Otherwise it's just an extra cognitive load on the
port's users and maintainer.

./danfe