From nobody Tue Feb 18 20:18:23 2025 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Yy9nt5VFwz5p7S6; Tue, 18 Feb 2025 20:18:26 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta004.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Yy9nt2Thkz3JDf; Tue, 18 Feb 2025 20:18:26 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4003a.ext.cloudfilter.net ([10.228.9.183]) by cmsmtp with ESMTPS id kNM2tvbKi5MqykU2ztPNCV; Tue, 18 Feb 2025 20:18:25 +0000 Received: from spqr.komquats.com ([70.66.136.217]) by cmsmtp with ESMTPSA id kU2ytcO18WbOakU2zt7tmw; Tue, 18 Feb 2025 20:18:25 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=Q5lx4J2a c=1 sm=1 tr=0 ts=67b4eb11 a=h7br+8Ma+Xn9xscxy5znUg==:117 a=h7br+8Ma+Xn9xscxy5znUg==:17 a=kj9zAlcOel0A:10 a=T2h4t0Lz3GQA:10 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=YxBL1-UpAAAA:8 a=9dQ5Ay4JtQ3NIWL6AOcA:9 a=CjuIK1q_8ugA:10 a=LK5xJRSDVpKd5WXXoEvA:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id A2FB1DF; Tue, 18 Feb 2025 12:18:23 -0800 (PST) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 722D6303; Tue, 18 Feb 2025 12:18:23 -0800 (PST) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Alexey Dokuchaev cc: Cy Schubert , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 9c1d7dcbc162 - main - www/dillo2: Add GIF option In-reply-to: References: <202502181831.51IIVlEb013253@gitrepo.freebsd.org> Comments: In-reply-to Alexey Dokuchaev message dated "Tue, 18 Feb 2025 19:42:54 +0000." List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 18 Feb 2025 12:18:23 -0800 Message-Id: <20250218201823.722D6303@slippy.cwsent.com> X-CMAE-Envelope: MS4xfNP9Np9S51MwKNdP5ELxXrW/iPa9Qq+o2pdifomNV/NUqyTF90R9n6MxeXW9IurYqQ1QUeYJwc0gIqUAKpxW/tOLJF4Q/Jj5ZOyj8SEEY4CklbT4tNCM /dcKWs1CcP9fswVgamojTmQmIhNJkH1lYLJgGhGayFXpR8ri/9a+1NWz4Ni6tubo1s6ldL2V8PZE2dOyl83aNqZEgjhc5IleoWuJUX7gzIeBDYsNHhja80ZC D7NXiVKrSDKlogwxwQwnJ2loZf+kjr1uXyOu588F0m0Ejrk75dDdzeedXD5IFH9Vj5i6yee+WqXftDJl1lxO14nclTUVsV7ItkhVBWkQYLXER1FvK0j3MLu2 HLWgA4UU X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Queue-Id: 4Yy9nt2Thkz3JDf X-Spamd-Bar: ---- In message , Alexey Dokuchaev writes: > On Tue, Feb 18, 2025 at 06:31:47PM +0000, Cy Schubert wrote: > > commit 9c1d7dcbc16262b2c2f10cb92be102de6a97638d > > > > www/dillo2: Add GIF option > > > > This option was enabled by default by the dillo2 ./configure. Add > > a knob to control this option. > > > > PORTNAME= dillo > > DISTVERSION= 3.1.1 > > +PORTREVISION= 1 > > If it's enabled by default, you don't need to bump. > > > +OPTIONS_DEFAULT= COOKIES GIF IPV6 JPEG PNG THREADS > > > > COOKIES_DESC= Cookie support > > HYPHENATION_DESC= Hyphenation file(s) for HYPHENATION_LANGS > > @@ -46,6 +47,8 @@ DEBUG_CONFIGURE_ENABLE= gprof rtfl > > > > COOKIES_CONFIGURE_ENABLE= cookies > > > > +GIF_CONFIGURE_ENABLE= gif > > + > > Since there's no accompanying LIB_DEPENDS, what's the reason to > add an option? If GIF support comes from the bundled library it > should have been mentioned in the commit log, otherwise I see no > reason to disable it. As far as I can tell there are no libraries removed (from ldd) when this default ./configure option is disabled. I suppose we can simply remove all the graphics options except for WEBP then. That woulod certainly simplify the port. > > ./danfe -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0