Re: git: b55acab768e0 - main - math/py-pystan: Deprecate and set expiration date to 2025-02-28

In reply to: Dan Langille: "Re: git: b55acab768e0 - main - math/py-pystan: Deprecate and set expiration date to 2025-02-28"
Go to: [ bottom of page ] [ top of archives ] [ this month ]
From: Daniel Engberg <diizzy_at_FreeBSD.org>
Date: Sat, 08 Feb 2025 18:53:14 UTC
Hi,

Fixed in d70d22536dd20366613a2c71c9dccaf08f4d78ed

Sorry about the breakage

Best regards,
Daniel

On 2025-02-08 19:30, Dan Langille wrote:
> On Sat, Feb 8, 2025, at 10:05 AM, Daniel Engberg wrote:
>> The branch main has been updated by diizzy:
>>
>> URL:
>> https://cgit.FreeBSD.org/ports/commit/?id=b55acab768e0c2d229adb542eca20815ccd7bef9
>>
>> commit b55acab768e0c2d229adb542eca20815ccd7bef9
>> Author:     Daniel Engberg <diizzy@FreeBSD.org>
>> AuthorDate: 2025-02-08 12:21:53 +0000
>> Commit:     Daniel Engberg <diizzy@FreeBSD.org>
>> CommitDate: 2025-02-08 13:51:17 +0000
>>
>>      math/py-pystan: Deprecate and set expiration date to 2025-02-28
>>     
>>      Marked as BROKEN for years so sunset port
>>     
>>      Approved by:    portmgr (blanket)
> 
> It's hard to write this without appearing snarky or rude. I apologize for that.
> 
> I am forwarding you a copy of the FreshPorts sanity test failure regarding
> this commit. If you could opt into the FreshPort sanity test feature, it would
> save both of us time and get things fixed faster.  Details are here:
> 
> https://docs.freebsd.org/en/books/porters-handbook/keeping-up/#freshports
> 
> Thank you.
> 
> ###
> 
> 
> Committer diizzy would have been notified of errors if they were opted in.
> 
> This message was generated by the FreshPorts Daemon.
> 
> You recently made this commit, which FreshPorts had trouble processing:
> 
> Commit : b55acab768e0c2d229adb542eca20815ccd7bef9
> Subject: math/py-pystan: Deprecate and set expiration date to 2025-02-28
> 
> The following is a list of the ports which had errors:
> 
> https://www.freshports.org/math/py-pystan/
> 
> 
> The exact errors appear below.
> 
> math/py-pystan:
> 
> This command (FreshPorts code 1):
> 
> /usr/local/bin/sudo /usr/sbin/jexec freshports /make-port.sh /usr/ports
> math/py-pystan
> 2>/tmp/FreshPorts.math.py-pystan.make-error.2025.2.8.15.6.39.19706
> 
> produced this error:
> 
> Error message is: make: "/usr/ports/Mk/bsd.port.mk" line 1810:
> Malformed conditional (${ARCH} == "amd64")
> make: "/usr/ports/Mk/bsd.port.mk" line 1840: Malformed conditional
> (${WITH_PKG} == devel)
> make: "/usr/ports/Mk/bsd.port.mk" line 2123: Malformed conditional
> (${PREFIX} == /usr)
> make: "/usr/ports/Mk/bsd.port.mk" line 3800: Malformed conditional
> (${UID} != 0 && !defined(INSTALL_AS_USER))
> make: "/usr/ports/Mk/bsd.port.mk" line 4707: Malformed conditional
> ((${PREFIX} != ${LOCALBASE} && ${PREFIX} != ${LINUXBASE} &&  ${PREFIX}
> != "/usr" && ${PREFIX} != "/" && !defined(NO_PREFIX_RMDIR)))
> make: "/usr/ports/Mk/bsd.port.mk" line 5530: Malformed conditional
> (${UID} != 0 && defined(_${:Uextract:tu}_REAL_SUSEQ) &&
> !defined(INSTALL_AS_USER))
> make: "/usr/ports/Mk/bsd.port.mk" line 5530: Malformed conditional
> (${UID} != 0 && defined(_${:Upatch:tu}_REAL_SUSEQ) &&
> !defined(INSTALL_AS_USER))
> make: "/usr/ports/Mk/bsd.port.mk" line 5530: Malformed conditional
> (${UID} != 0 && defined(_${:Uconfigure:tu}_REAL_SUSEQ) &&
> !defined(INSTALL_AS_USER))
> make: "/usr/ports/Mk/bsd.port.mk" line 5530: Malformed conditional
> (${UID} != 0 && defined(_${:Ubuild:tu}_REAL_SUSEQ) &&
> !defined(INSTALL_AS_USER))
> make: "/usr/ports/Mk/bsd.port.mk" line 5530: Malformed conditional
> (${UID} != 0 && defined(_${:Ustage:tu}_REAL_SUSEQ) &&
> !defined(INSTALL_AS_USER))
> make: "/usr/ports/Mk/bsd.port.mk" line 5530: Malformed conditional
> (${UID} != 0 && defined(_${:Uinstall:tu}_REAL_SUSEQ) &&
> !defined(INSTALL_AS_USER))
> make: "/usr/ports/Mk/bsd.port.mk" line 5530: Malformed conditional
> (${UID} != 0 && defined(_${:Upackage:tu}_REAL_SUSEQ) &&
> !defined(INSTALL_AS_USER))
> make: Fatal errors encountered -- cannot continue
> Make results are : make: stopped in /usr/ports/math/py-pystan
> 
> 
> ###
> 
>> ---
>>   math/py-pystan/Makefile | 11 ++++-------
>>   1 file changed, 4 insertions(+), 7 deletions(-)
>>
>> diff --git a/math/py-pystan/Makefile b/math/py-pystan/Makefile
>> index 2b2d8316e177..5a87ea982c6f 100644
>> --- a/math/py-pystan/Makefile
>> +++ b/math/py-pystan/Makefile
>> @@ -12,16 +12,13 @@ WWW=		https://github.com/stan-dev/pystan
>>   LICENSE=	GPLv3
>>   LICENSE_FILE=	${WRKSRC}/LICENSE
>>
>> +BROKEN=		several build errors
>> +DEPRECATED=	Marked as BROKEN for years
>> +EXPIRATION_DATE=2025-02-28
>> +
>>   USES=		compiler:c++14-lang python shebangfix
>>   USE_PYTHON=	autoplist distutils
>>
>> -.include <bsd.port.pre.mk>
>> -
>> -.if ${PYTHON_REL} >= 30900
>> -# See PR 262797 - to be upgraded after the modernization of OCaml ports
>> -BROKEN=		several build errors
>> -.endif
>> -
>>   BUILD_DEPENDS+=	${PYTHON_PKGNAMEPREFIX}cython>0:lang/cython@${PY_FLAVOR}
>>   BUILD_DEPENDS+=	${PYTHON_PKGNAMEPREFIX}numpy>0:math/py-numpy@${PY_FLAVOR}
>