Re: git: 192c4d399bd4 - main - security/p5-Authen-SASL: Use upstream version scheme
Date: Mon, 18 Aug 2025 08:05:55 UTC
Am 18.08.25 um 09:25 schrieb Alexey Dokuchaev:
> On Sat, Aug 16, 2025 at 01:35:30PM +0200, Matthias Andree wrote:
>> Am 16.08.25 um 13:25 schrieb Ronald Klop:
>>> I think the preferred variable is now DISTVERSION (upstream version)
>>> instead of PORTVERSION (local version). Although in practice it does
>>> not change the functionality of the port AFAIK.
>>
>> Yep, current wording of the porter's handbook suggests that you're right.
>
> I find this PHB part misleading and even harmful. Traditional approach
> (start with PORTVERSION and only fallback to DISTVERSION for ill-formed
> versions) is IMHO more robust and error-resistant, not to mention more
> logical (PORT{NAME,VERSION,REVISION} triad).
Care to explain why that would be "harmful"? Why is it not irrelevant
which variable copies from which other if the value is adequate for both?
>> So unless we version the porter's handbook and point out important
>> changes, how am I or are we to learn the preference after some 20 years?
>
> Keep using PORTVERSION like your muscle memory and common sense suggest or
> DISTVERSION if one prefers it as most of the times they're interchangeable.
I'll make my own decisions, thanks.
--
Matthias Andree
FreeBSD ports committer