From nobody Mon Aug 11 05:34:03 2025 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c0jxP2gLcz64DBw; Mon, 11 Aug 2025 05:34:17 +0000 (UTC) (envelope-from bsdkaffee@gmail.com) Received: from mail-vs1-f42.google.com (mail-vs1-f42.google.com [209.85.217.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c0jxM70kNz3Hvd; Mon, 11 Aug 2025 05:34:15 +0000 (UTC) (envelope-from bsdkaffee@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of bsdkaffee@gmail.com designates 209.85.217.42 as permitted sender) smtp.mailfrom=bsdkaffee@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none) Received: by mail-vs1-f42.google.com with SMTP id ada2fe7eead31-4fbf83972d4so1315665137.1; Sun, 10 Aug 2025 22:34:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754890455; x=1755495255; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f/mmYv1APnkUjJ8OeA0cLDVa6goXs1w6N3kUjfNfkeM=; b=wf9s54IqrQo/dy3n3AFabAYDJ1p2ZaSqlU5Qp76sbBAh3R6Dufz1DnMjMKqKEL0Zco 1JQtQYnNTmnhsIZV9IzwZuQ05BpeG325RZ6Julpih7bwQG13EsHgCWRkeesCsrnnUo0X oHUA9pDeYGZ4IBLpxN8oHsFAJjH36ox/hsi4PYvyeuP9TFJZJdg0VS8ra326Qln690f1 FKocAiF0dSn0lojvm848T2m/dIPyTxsauqhEDArWJ74GJDyu1ixQw52CoaGillFMWMgU XfqRRBw3WI1qJHfXls2Zs2/go4L6OvmjHMte+e/+EiGC35T0aKvKr2Wn4PHg4g3MQYe1 ctEg== X-Forwarded-Encrypted: i=1; AJvYcCV8P/RMR//BY/kspEr+CUs3eqtKvDRYLsRFgZPl5SwZAteuNf2z8Eyk4NXe+JivwA6pyL1O0TW3NzlygYoSqSVqVA==@freebsd.org, AJvYcCVLEhWeIw0baCwAnehcaDpDM5k0CVzAkUEbvE7sqbQQV0FVrvVHSkQanf1WWEsGKUu3tiXpU8lKbjNg9eXTViDVZvMi4Ucceg==@freebsd.org, AJvYcCW65fCeH1bVaLaI5tOSINO+RoFeby/pToSDROl23jIx4KtC7GEbIzcEAnfKdDgJcr1irjKQyA==@freebsd.org, AJvYcCWD2MV8l6lYei67I8B7M+deqovhJcyCpHLAjg3v7dKLYfKczvUjfKvnx5ulso4ozf9Hf5siM00Mf/8KLaX374NgV5k0vHY=@freebsd.org, AJvYcCXscQ1yYHtEWMcLUlI7cH7LA253wp9cjXR3sdWISAEzKpq3vjHSdYa2V+Q5Zi7gTUGM1tIXdrlI@freebsd.org X-Gm-Message-State: AOJu0YxGyo8RrvYzKURNM6ZxxN/M0WwU7BMmo3QLTBMfMFa54spUC5Xa MoPwgDyQ3yCAKXVkKXX6VpqMcUv8n0c+Q80R6N1KU8jrRi4gEjbu5LFuQa6ZIPmysFJYuUPZhq9 fd+LbXyqrcFrlQJGfbM+Nt2J0wg0aKE+s6c6I X-Gm-Gg: ASbGnct78zC8jZQIzURJm+VwOCLsg0zwg6f/ZBUPtUgwumn2vI6B0QZjZWl2CwT6hnv WZoIS+KGJ1aN1CGGJFeKiUF7qZCaq0kwPhxdtcsFuCNckK5AZSsxHMydI+ehsf6iDItds6CPuTo uLwlSQJ+RtJMJiNAqc7RTsV2XJVD05Dk7UcHu8VSmTkWkYTRdyFkz+olxz3BA6yAbbz/cjxiTaV zuKJc7M X-Google-Smtp-Source: AGHT+IGkf09bjqMu9Iq4XwphBb9eEareUqbPNYhJr1zDqIa2GjHSWUdzySTWl1fAiNF+/2tQPAitNwQylmoc9ty6pMw= X-Received: by 2002:a05:6102:c93:b0:4fa:156c:b814 with SMTP id ada2fe7eead31-5060ecd5fa5mr3793199137.23.1754890454801; Sun, 10 Aug 2025 22:34:14 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 References: <202508060822.5768M6pK040832@gitrepo.freebsd.org> <2363855.mfXeX5GmMH@mercury> <20250809152154.90ffc1a3e54e5a1a7031e35a@bidouilliste.com> <2743956.TYJnH3iKXO@mercury> In-Reply-To: <2743956.TYJnH3iKXO@mercury> From: "Jason E. Hale" Date: Mon, 11 Aug 2025 01:34:03 -0400 X-Gm-Features: Ac12FXzOA_6_ghc4VaSVqV-X76FGczYFrtz9XdYRWqkUzqX654MtpIklRV8GqEs Message-ID: Subject: Re: git: b991d37c58ed - main - graphics/wayland: Remove libm from pkgconfig Libs To: Max Brazhnikov Cc: Emmanuel Vadot , Emmanuel Vadot , Jan Beich , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-2.34 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.88)[-0.876]; NEURAL_HAM_MEDIUM(-0.57)[-0.568]; FORGED_SENDER(0.30)[jhale@freebsd.org,bsdkaffee@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; RCVD_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.217.42:from]; MLMMJ_DEST(0.00)[dev-commits-ports-all@freebsd.org,dev-commits-ports-main@freebsd.org]; RCVD_TLS_LAST(0.00)[]; FROM_NEQ_ENVFROM(0.00)[jhale@freebsd.org,bsdkaffee@gmail.com]; R_DKIM_NA(0.00)[]; MISSING_XM_UA(0.00)[]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_IN_DNSWL_NONE(0.00)[209.85.217.42:from] X-Rspamd-Queue-Id: 4c0jxM70kNz3Hvd X-Spamd-Bar: -- On Sat, Aug 9, 2025 at 9:59=E2=80=AFAM Max Brazhnikov wr= ote: > > On Sat, 9 Aug 2025 15:21:54 +0200 Emmanuel Vadot wrote: > > On Sat, 09 Aug 2025 14:11:34 +0300 > > Max Brazhnikov wrote: > > > > > On Fri, 08 Aug 2025 15:07:58 +0200 Jan Beich wrote: > > > > Emmanuel Vadot writes: > > > > > > > > > This changes seems to confuse CMake for some unknown reason s= o for now > > > > > remove libm from the Libs section, it's in the Libs.private s= o it's picked up > > > > > just fine. > > > > > > > > > > Fixes: 9e3878cf8428 ("graphics/wayland: Update to 1.24.0") > > > > > Sponsored by: Beckhoff Automation GmbH & Co. KG > > > > > > > > Do you plan to file a bug upstream? If you break API fixes cannot b= e upstreamed. > > > > > > I think this workaround should be reverted. > > > > No. > > > > > If other ports fails with wayland-1.24, they should be fixed or > > > > Those ports shouldn't fail with what was originally in wayland 1.24 > > and shouldn't be patched. > > Emmanuel, could you provide an example port to reproduce the your problem= , please? > > > > if outdated ninja-1.11 is the culprit, it should be updated. > > > > Go ahead, I know nothing about ninja, I don't even know if that's the > > culprit but if it is then and only then I'll revert my hack. > > The hack is wrong, ports fail with it: > > https://cgit.freebsd.org/ports/commit/?id=3Df2d9466e25660bc430e3d092df9f9= bb7f660ce84 > https://cgit.freebsd.org/ports/commit/?id=3Da208f76c57a5ecb5723b9a0d95d63= 71b7ded507f > https://cgit.freebsd.org/ports/commit/?id=3D3e6a8fffef6d6b0318e7ee3cf8fe3= dc09352c9cd > > while they build just fine without the wayland hack. > > Cheers, > Max > > Emmanuel, Max figured out that it was graphics/vulkan-tools that was failing in a discussion on #freebsd-desktop, but he is busy for a few days and asked the rest of the kde@ team to figure this out. From what I can tell, vulkan-tools upstream fixed this in [1]. The port builds fine with this change reverted and [1] applied. I also think this commit should definitely be reverted and say we fix any other potentially broken ports with stock wayland since this commit seems to be breaking at least 3 other ports as cited above by Max. In the case of vulkan-tools, these were poor CMake constructs that just happened to work previously and are neither bugs with ninja nor with CMake. [1] https://github.com/KhronosGroup/Vulkan-Tools/commit/105d6c1fede00c3a905= 5e5a531ebf3d99bac406e - Jason