Re: git: b991d37c58ed - main - graphics/wayland: Remove libm from pkgconfig Libs

On Sat, 9 Aug 2025 15:21:54 +0200 Emmanuel Vadot wrote:
> On Sat, 09 Aug 2025 14:11:34 +0300
> Max Brazhnikov <makc@freebsd.org> wrote:
> 
> > On Fri, 08 Aug 2025 15:07:58 +0200 Jan Beich wrote:
> > > Emmanuel Vadot <manu@FreeBSD.org> writes:
> > > 
> > > >     This changes seems to confuse CMake for some unknown reason so for now
> > > >     remove libm from the Libs section, it's in the Libs.private so it's picked up
> > > >     just fine.
> > > >
> > > >     Fixes:  9e3878cf8428 ("graphics/wayland: Update to 1.24.0")
> > > >     Sponsored by:   Beckhoff Automation GmbH & Co. KG
> > > 
> > > Do you plan to file a bug upstream? If you break API fixes cannot be upstreamed.
> > 
> > I think this workaround should be reverted. 
> 
>  No.
> 
> > If other ports fails with wayland-1.24, they should be fixed or
> 
>  Those ports shouldn't fail with what was originally in wayland 1.24
> and shouldn't be patched.

Emmanuel, could you provide an example port to reproduce the your problem, please?

> > if outdated ninja-1.11 is the culprit, it should be updated.
> 
>  Go ahead, I know nothing about ninja, I don't even know if that's the
> culprit but if it is then and only then I'll revert my hack.

The hack is wrong, ports fail with it:

https://cgit.freebsd.org/ports/commit/?id=f2d9466e25660bc430e3d092df9f9bb7f660ce84
https://cgit.freebsd.org/ports/commit/?id=a208f76c57a5ecb5723b9a0d95d6371b7ded507f
https://cgit.freebsd.org/ports/commit/?id=3e6a8fffef6d6b0318e7ee3cf8fe3dc09352c9cd

while they build just fine without the wayland hack.

Cheers,
Max