Re: git: ce3687b1f659 - main - sysutils/sensors: new port, show sensors/temperatures info

From: Alexey Dokuchaev <danfe_at_freebsd.org>
Date: Mon, 04 Aug 2025 08:10:42 UTC 
On Sat, Aug 02, 2025 at 11:53:06AM +0000, ??lven wrote:
> commit ce3687b1f6590796c17405040d70fdf6f4977e9f
> 
>   sysutils/sensors: new port, show sensors/temperatures info

Hello Alven, could you please put your full name in GECOS like the rest of us do?

> +MASTER_SITES=	https://github.com/vermaden/sensors/raw/master/release/:source \
> +		https://github.com/vermaden/sensors/raw/master/:license
> +DISTFILES=	${DISTNAME}${EXTRACT_SUFX}:source \
> +		LICENSE:license
> +DIST_SUBDIR=	${PORTNAME}

Why all these dances just to download another copy of standard license?  You
don't need to set LICENSE_FILE, the LICENSE=BSD2CLAUSE alone would suffice here.

> +NO_ARCH=	YES
> +NO_BUILD=	YES

We spell this type of knobs' values with lowercase in ports.

> +do-install:
> +	${INSTALL_SCRIPT} ${WRKSRC}/sensors \
> +	${STAGEDIR}${PREFIX}/sbin/${PORTNAME}

Broken (confusing) indentation here.

> +++ b/sysutils/sensors/pkg-descr
> @@ -0,0 +1 @@
> +Show sensors(8) and temperatures on FreeBSD UNIX system.

This is way too concise for a port description; portlint(1) should have
warned you about it.

./danfe