From nobody Tue Apr 29 04:53:42 2025 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Zmnyb3gzjz5vQYb; Tue, 29 Apr 2025 04:53:43 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZmnyZ4dvyz3Nbd; Tue, 29 Apr 2025 04:53:42 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745902422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mXRU7om6SokWz+VXEQwN8N8A2KaqhIAjT/efsCUy/mg=; b=ntWyPVzUCl8ux2gc/8wnogwKGCHhlEBeriyAtrjzXU0jwmetxaXPjj6UaySCyDmd/rbEcX 25p+6De+sDehIvgzx+LzqVntNjPTK4nwPbU3MSAy6MpNOly4GC1W8lQQgAj5FdIgZ96Dwt pkPIbMrDQ5jCWvHjDTYH97qMMl3qBmcjL3nO1HNP9tYa8FRLBkLiVN4G/aTndHvnomZwcd p7keIrvqh2ABO4XcttWYSeKOheV/etYzfOlK1p3kPGyvj+DPpzdl3W5qhC+0bvNZeGClvJ V7Kk4ItNy58n/I/RPEFzvz/881ge2uJ7EfhcaR6AXgpelW9LeEq4/gEepcFTCw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1745902422; a=rsa-sha256; cv=none; b=uP1VHXzayb0F1b1m/8mhEzVY/hfDpWaOltqxArU2/zptI2vPxW2EMm7kVH9GhcUl2U6KFg y1/+Z6duPIVgACR63dgCPMoQJQ2KMgcfl1GubVwsC16jg7o03IgCK/tzl8Mhsw0VQIJrw4 PoPqfed7utphXyAlsvidheGsok/rXJc/X63X3hCXENZLALioAGE+BD9QxfeMtSXde1zqYD PRO6tbZubq0rjqLy9e7LDcUEFRlzLw9dUVfjpx5GbMPdo3xXxgYGcHcG0hmeoAPHgYXXQx dyOyy2T0kj2rG3iikf7wf17PtLQkTBynZxELmrNxbsWmxRVva+1s6qyxh5jXBg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745902422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mXRU7om6SokWz+VXEQwN8N8A2KaqhIAjT/efsCUy/mg=; b=TlFA8IiB1cYs+9iDau620x/clYSb3azi2hLxPZ0LgIv+f/OXAPq01TXENY33CLPqZroVdN F7qyodVVgp4MYTT3n0RnNPn6YCb1xPKrNKWGAGJNydz61FqvgQETewHbPgsKOvp1jVQm6W TGFTv/Ce1ZGUb++d1aqQvFRyfQQPToBDYe97POvkV/vEy8yEB+nwHDy9mmEE2lkV/cKxoq sMmbp018iOC7tSO9EMVeb5cU8yPhA1zmfLzwVj99NbS/MSNk96UkCKX5E79PwoxoDaruiD sMrjvXS/8sXRxWGdMP95l2Tfs2tt+8xJV3zSUGnzpVENw2/Dxx5bgXV3434zJA== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 762AD15CA; Tue, 29 Apr 2025 04:53:42 +0000 (UTC) Date: Tue, 29 Apr 2025 04:53:42 +0000 From: Alexey Dokuchaev To: Gleb Popov Cc: Cy Schubert , Vladimir Druzenko , Cy Schubert , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: a8b4678fc925 - main - emulators/virtualbox-ose-70: Fix 15-CURRENT kmod build Message-ID: References: <202504282032.53SKWSwG044334@gitrepo.freebsd.org> <75d70616-d0ad-4c29-818d-25a21ba0042d@freebsd.org> <20250428162831.11f887a8@slippy> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Apr 29, 2025 at 07:46:16AM +0300, Gleb Popov wrote: > On Tue, Apr 29, 2025 at 7:43???AM Alexey Dokuchaev wrote: > > > > Seeing those context lines gone should've ring a bell that you're preparing > > your patches in a different and perhaps unconventional way. We typically > > regenerate patches with "make makepatch" which takes are of proper headers, > > timestamps, and context quoting. Try it next time, it is awesome! :-) > > make makepatch also regenerates irrelevant hunks if offsets get changed. > > If one wants to commit only the relevant changes, the way to go is > "git restore -p" to first drop irrelevant ones. Of course. One should cleanup (re)generated patches and any changes in general prior to commit to reduce the diff noise. Unfortunately, people seldom do that. ./danfe