Re: git: a8b4678fc925 - main - emulators/virtualbox-ose-70: Fix 15-CURRENT kmod build

On Tue, Apr 29, 2025 at 07:46:16AM +0300, Gleb Popov wrote:
> On Tue, Apr 29, 2025 at 7:43???AM Alexey Dokuchaev <danfe@freebsd.org> wrote:
> >
> > Seeing those context lines gone should've ring a bell that you're preparing
> > your patches in a different and perhaps unconventional way.  We typically
> > regenerate patches with "make makepatch" which takes are of proper headers,
> > timestamps, and context quoting.  Try it next time, it is awesome! :-)
> 
> make makepatch also regenerates irrelevant hunks if offsets get changed.
> 
> If one wants to commit only the relevant changes, the way to go is
> "git restore -p" to first drop irrelevant ones.

Of course.  One should cleanup (re)generated patches and any changes in
general prior to commit to reduce the diff noise.  Unfortunately, people
seldom do that.

./danfe