Re: git: cbc634d294a2 - main - net-mgmt/prometheus3: Add new port

From: Sergey A. Osokin <osa_at_freebsd.org>
Date: Sun, 20 Apr 2025 15:41:33 UTC
Hi Danilo,

thank you very much for the new port.

On Sun, Apr 20, 2025 at 11:30:05AM +0000, Danilo Egea Gondolfo wrote:
> The branch main has been updated by danilo:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=cbc634d294a29f149b500d5a81b78efe99aeaf9d
> 
> commit cbc634d294a29f149b500d5a81b78efe99aeaf9d
> Author:     Danilo Egea Gondolfo <danilo@FreeBSD.org>
> AuthorDate: 2025-04-20 11:18:44 +0000
> Commit:     Danilo Egea Gondolfo <danilo@FreeBSD.org>
> CommitDate: 2025-04-20 11:25:35 +0000
> 
>     net-mgmt/prometheus3: Add new port
>     
>     Add Prometheus 3.3.0, released on 2025-04-15, to the Ports tree.

[...]

> +CONFLICTS_INSTALL=	prometheus1 prometheus

Wouldn't be better to slightly changed this to the following?

-CONFLICTS_INSTALL=	prometheus1 prometheus
+CONFLICTS_INSTALL=	prometheus[12]

Also, I belive that other net-mgmt/prometheus* ports' Makefiles need to be
updated as well, i.e.:

for net-mgmt/prometheus1:

+CONFLICTS_INSTALL=   prometheus[23]

for net-mgmt/prometheus2:

+CONFLICTS_INSTALL=   prometheus[13]

Please let me know your thoughts.  Note: the change hasn't been tested yet.

Thank you.

-- 
Sergey A. Osokin