Re: git: 3b8c51bd37b0 - main - devel/boost-all: Use clang from base for OSVERSION >= 1500017

From: Dimitry Andric <dim_at_FreeBSD.org>
Date: Sat, 23 Mar 2024 17:15:20 UTC
On 23 Mar 2024, at 18:09, Yasuhiro Kimura <yasu@FreeBSD.org> wrote:
> 
> From: Dimitry Andric <dim@FreeBSD.org>
> Subject: git: 3b8c51bd37b0 - main - devel/boost-all: Use clang from base for OSVERSION >= 1500017
> Date: Sat, 23 Mar 2024 12:40:31 GMT
> 
>> The branch main has been updated by dim:
>> 
>> URL: https://cgit.FreeBSD.org/ports/commit/?id=3b8c51bd37b02a367217533a1bf0761655a77570
>> 
>> commit 3b8c51bd37b02a367217533a1bf0761655a77570
>> Author:     Dimitry Andric <dim@FreeBSD.org>
>> AuthorDate: 2024-03-23 12:29:07 +0000
>> Commit:     Dimitry Andric <dim@FreeBSD.org>
>> CommitDate: 2024-03-23 12:39:00 +0000
>> 
>>    devel/boost-all: Use clang from base for OSVERSION >= 1500017
>> 
>>    In https://cgit.freebsd.org/src/commit/?id=bcd401b5a39c I committed a
>>    fix for clang's assertion failures when building recent boost libraries.
>>    I also bumped __FreeBSD_version to 1500017 so this can be detected from
>>    devel/boost-all/compiled.mk.
>> 
>>    The fix was also merged to stable/14, with __FreeBSD_version 1400509,
>>    and stable/13, with __FreeBSD_version 1303502.
>> 
>>    Adjust the ranges to use the default llvm port to [1500000..1500017>,
>>    [1400000..1400509>, and [1300000..1303502>.
>> 
>>    PR:             277850
>>    Approved by:    fluffy (maintainer)
>>    MFH:            2024Q1
> 
> As I reported in bug 269067, assertion failure happens if clang in
> base system is used to build devel/boost-libs after it is updated to
> 1.81.0. But it only happens with -CURRENT as LLVM_ASSERTIONS option is
> enabled only with main branch of src repository. So we need not use
> llvm from ports to build devel/boost-libs on either -STABLE or
> -RELEASE. And the range should be adjusted to [1500000..1500017> and
> [1400000..1400097>.

I'm fine with that, sure. Users can optionally set WITH_LLVM_ASSERTIONS
on stable or even release branches, but I guess the number of people
doing that is low.

-Dimitry