Re: git: ea45a9a53499 - main - cad/PrusaSlicer: Mark BROKEN
Date: Thu, 07 Mar 2024 11:22:09 UTC
On Wed, Mar 6, 2024 at 10:34 PM Daniel Engberg <
daniel.engberg.lists@pyret.net> wrote:
> On 2024-03-04T18:34:16.000+01:00, Fernando Apesteguía <
> fernando.apesteguia@gmail.com> wrote:
> > On Sun, Mar 3, 2024 at 8:36 PM Daniel Engberg <diizzy@freebsd.org>
> wrote:
> >
> >
> > > The branch main has been updated by diizzy:
> > >
> > > URL:
> > >
> https://cgit.FreeBSD.org/ports/commit/?id=ea45a9a534994a1bf97a162168902cebbca1f4c1
> > >
> > > commit ea45a9a534994a1bf97a162168902cebbca1f4c1
> > > Author: Daniel Engberg <diizzy@FreeBSD.org>
> > > AuthorDate: 2024-03-03 08:29:04 +0000
> > > Commit: Daniel Engberg <diizzy@FreeBSD.org>
> > > CommitDate: 2024-03-03 19:26:10 +0000
> > >
> > > cad/PrusaSlicer: Mark BROKEN
> > >
> > > Fails to build, error: no member named 'prior' in namespace
> 'boost'
> > >
> > > Reported by: pkg-fallout
> > > ---
> > > cad/PrusaSlicer/Makefile | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/cad/PrusaSlicer/Makefile b/cad/PrusaSlicer/Makefile
> > > index dc125244df20..936e76216daf 100644
> > > --- a/cad/PrusaSlicer/Makefile
> > > +++ b/cad/PrusaSlicer/Makefile
> > > @@ -12,6 +12,8 @@ WWW= https://www.prusa3d.com/prusaslicer/
> > > LICENSE= AGPLv3
> > > LICENSE_FILE= ${WRKSRC}/LICENSE
> > >
> > > +BROKEN= fails to build, error: no member named
> 'prior' in
> > > namespace 'boost'
> > > +
> > >
> >
> > Can we revert this?
> > It is an issue with math/cgal and not cad/PrusaSlicer (
> > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277480)
>
>
> > Cheers.
> >
> >
> >
> > > BUILD_DEPENDS= cereal>=1.3.0.10:devel/cereal \
> > > cgal>=5.0.2:math/cgal \
> > > opencascade>=7.7.0:cad/opencascade
> >
>
> Hi,
>
> It breaks Prusaslicer either way?
>
> https://pdr2.bofh.network/data/140-diizzy/2024-03-02_16h50m15s/logs/errors/PrusaSlicer-2.6.0_8.log
I just realized I didn't attach the patch to the PR :S
It is attached now.
With that patch in math/cgal, cad/PrusaSlicer builds fine.
My main point is this. We should mark ports as BROKEN when *they* are
broken, not when the dependencies are.
Otherwise, if/when the dependency is fixed those ports would remain marked
as BROKEN unless someone keeps track of what ports where marked that way
because of a flaw in the dependency.
There are 9 ports depending on math/cgal.I didn't check if any other ports
are broken, but any port that includes the same header from math/cgal will
fail to build unless they also include boost/next_prior.hpp by any chance
The patch in the PR should be upstreamed too and/or math/cgal.
>
>
> Best regards,
> Daniel
>