Re: git: 187b969b8f9f - main - graphics/svgpp: new port had been added (+)

On 2024-06-09T08:26:14.000+02:00, Alexey Dokuchaev <danfe@FreeBSD.org>
wrote:

> The branch main has been updated by danfe:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=187b969b8f9f0ed850f0dc7eb8d08b6d961f1346
> 
> commit 187b969b8f9f0ed850f0dc7eb8d08b6d961f1346
> 
> Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
> 
> AuthorDate: 2024-06-09 06:25:00 +0000
> 
> Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
> 
> CommitDate: 2024-06-09 06:25:00 +0000
> 
>     graphics/svgpp: new port had been added (+)
> 
>     
> 
>     SVG++ library can be thought of as a framework, containing parsers
> 
>     for various SVG syntaxes, adapters that simplify handling of parsed
> 
>     data, and other utilities and helpers for the most common tasks.
> 
>     
> 
>     WWW: http://svgpp.org/
> 
> ---
> 
>  graphics/Makefile        |   1 +
> 
>  graphics/svgpp/Makefile  |  20 +++++
> 
>  graphics/svgpp/distinfo  |   3 +
> 
>  graphics/svgpp/pkg-descr |   3 +
> 
>  graphics/svgpp/pkg-plist | 192 +++++++++++++++++++++++++++++++++++++++++++++++
> 
>  5 files changed, 219 insertions(+)
> 
> diff --git a/graphics/Makefile b/graphics/Makefile
> 
> index 8e12cafd0e4e..4a3bb391f03a 100644
> 
> --- a/graphics/Makefile
> 
> +++ b/graphics/Makefile
> 
> @@ -1152,6 +1152,7 @@
> 
>      SUBDIR += svg2png
> 
>      SUBDIR += svgalib
> 
>      SUBDIR += svgbob
> 
> +    SUBDIR += svgpp
> 
>      SUBDIR += swappy
> 
>      SUBDIR += swfmill
> 
>      SUBDIR += swftools
> 
> diff --git a/graphics/svgpp/Makefile b/graphics/svgpp/Makefile
> 
> new file mode 100644
> 
> index 000000000000..505090385589
> 
> --- /dev/null
> 
> +++ b/graphics/svgpp/Makefile
> 
> @@ -0,0 +1,20 @@
> 
> +PORTNAME=    svgpp
> 
> +PORTVERSION=    1.3.1
> 
> +DISTVERSIONPREFIX=    v
> 
> +CATEGORIES=    graphics
> 
> +
> 
> +MAINTAINER=    danfe@FreeBSD.org
> 
> +COMMENT=    C++ header-only parsers for various SVG syntaxes
> 
> +WWW=        http://svgpp.org/
> 
> +
> 
> +LICENSE=    BSL
> 
> +LICENSE_FILE=    ${WRKSRC}/LICENSE_1_0.txt
> 
> +
> 
> +USE_GITHUB=    yes
> 
> +NO_BUILD=    yes
> 
> +NO_ARCH=    yes
> 
> +
> 
> +do-install:
> 
> +    ${CP} -a ${WRKSRC}/include/ ${STAGEDIR}${PREFIX}/include
> 
> +
> 
> +.include <bsd.port.mk> [http://bsd.port.mk>];
> 
> ...

Hi,

While this works you can please consider to follow Porters
Handbookregarding use of USE_GITHUB section (see examples) and
COPYTREE_SHARE macro instead of cp for consistency?

https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github

https://docs.freebsd.org/en/books/porters-handbook/book/#install-copytree

Best regards,

Daniel