Re: git: c841c52f8c28 - main - x11/sfwbar: Install mans to share and sort plist.

From: Moin Rahman <bofh_at_freebsd.org>
Date: Fri, 12 Jan 2024 12:27:50 UTC 

> On Jan 12, 2024, at 1:26 PM, Jan Beich <jbeich@FreeBSD.org> wrote:
> 
> Gleb Popov <arrowd@FreeBSD.org> writes:
> 
>>   x11/sfwbar: Install mans to share and sort plist.
> 
> Mixing style and functional changes makes pkg-plist diff hard to read.
> See also https://docs.freebsd.org/en/articles/committers-guide/#_other_suggestions
> 
>> -MESON_ARGS= -Dbsdctl=enabled -Dnetwork=enabled -Dbluez=enabled -Didleinhibit=enabled -Diwd=enabled
>> +MESON_ARGS= -Dbsdctl=enabled -Dnetwork=enabled -Dbluez=enabled \
>> + -Didleinhibit=enabled -Diwd=enabled --mandir=share/man
> 
> Why not fix USES=meson itself?
> 
> diff --git a/Mk/Uses/meson.mk b/Mk/Uses/meson.mk
> index ae997ae1a337..3a6ae041ff97 100644
> --- a/Mk/Uses/meson.mk
> +++ b/Mk/Uses/meson.mk
> @@ -33,7 +33,7 @@ BUILD_DEPENDS+= meson:devel/meson
> USE_LOCALE?= en_US.UTF-8
> 
> CONFIGURE_ARGS+= --prefix ${PREFIX} \
> - --mandir man \
> + --mandir share/man \
> --infodir ${INFO_PATH}
> 
> # Enable all optional features to make builds deterministic. Consumers can

Incoming tonight.

Kind regards,
Moin