Re: git: 3eadab0ea3ae - main - games/tomenet: unbreak the port, undeprecate, respect CFLAGS better.

On Sun, Dec 31, 2023 at 01:07:42AM +0000, Alexey Dokuchaev wrote:
> On Sat, Dec 30, 2023 at 05:56:48PM +0000, Rene Ladan wrote:
> > On Sat, Dec 30, 2023 at 02:44:18PM +0000, Alexey Dokuchaev wrote:
> > > commit 3eadab0ea3ae60cde9ffaa21c0caa71f48563827
> > > 
> > >   games/tomenet: unbreak the port, undeprecate, respect CFLAGS better.
> > > ---
> > > -DEPRECATED=	BROKEN for more than 2 years on all supported versions after the EOL of 12
> > > -EXPIRATION_DATE=	2023-12-31
> > > -BROKEN_FreeBSD_13=	ld: error: duplicate symbol: lite_later
> > > -BROKEN_FreeBSD_14=	ld: error: duplicate symbol: lite_later
> > 
> > And there was no time in the past two years for you to fix this
> > port before?
> 
> I was one of several who helped to fix initial bulk of broken ports
> after -fno-common was enforced, this one probably slipped through
> the cracks, but better late than never, no? :)
> 
> The real question one should be asking, however, is why mark these
> ports BROKEN in the first place rather than fix them right away.

I think I already wrote this to you many times, but it seems you always
ask the question, so it does not sink in.

Portmgr's role is a managing one, in this regard, it is to curate the
ports tree, not to fix broken ports.

-- 
Mathieu Arnold