Re: git: fabf8b5d1165 - main - Mk/bsd.default-versions.mk: Switch SAMBA default to 4.16

Am 2024-01-01 16:17, schrieb Alexander Leidinger:
> Am 2023-12-31 05:26, schrieb Muhammad Moinur Rahman:
>> The branch main has been updated by bofh:
>> 
>> URL: 
>> https://cgit.FreeBSD.org/ports/commit/?id=fabf8b5d116512e2c0339c1a17340370d753e271
>> 
>> commit fabf8b5d116512e2c0339c1a17340370d753e271
>> Author:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
>> AuthorDate: 2023-12-31 01:29:20 +0000
>> Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
>> CommitDate: 2023-12-31 03:51:03 +0000
>> 
>>     Mk/bsd.default-versions.mk: Switch SAMBA default to 4.16
> 
> I have tried samba 4.16 after this commit on FreeBSD-current in a jail. 
> This doesn't work. The samba shares are physically on zfs, which are 
> nullfs mounted into a jail which runs samba and exports to Windows 11 
> and Windows 10. I can see the directory contents, but when I try to 
> access a file (e.g. text file), Windows tells me it can not access the 
> file. The samba log contains in the log log.<windows_host_name> the 
> lines
> ---snip---
> [2024/01/01 16:01:16.059649,  0] 
> ../../source3/modules/vfs_zfsacl.c:363(fget_zfsacl)
>   fget_zfsacl: fdescfs filesystem must be mounted with 'nodup' option
> ---snip---

Changing 
files/0099-s3-modules-zfsacl-fix-get-set-ACL-on-FreeBSD-13.patch to 
comment out (=workaround) this (2 times) makes it work:
---snip---
+/*             if (!fsp->fsp_flags.have_proc_fds) {
+                       DBG_ERR("fdescfs filesystem must be mounted with 
'nodup' "
+                               "option \n");
+                       errno = EBADF;
+                       return -1;
+               }*/
---snip---

So the check for have_proc_fds for jails is not correct.

Bye,
Alexander.

-- 
http://www.Leidinger.net Alexander@Leidinger.net: PGP 0x8F31830F9F2772BF
http://www.FreeBSD.org    netchild@FreeBSD.org  : PGP 0x8F31830F9F2772BF