Re: git: 4dc04ac964f8 - main - net/libngtcp2: Update to 1.3.0

On 2024-02-21T16:19:24.000+01:00, Po-Chuan Hsieh <sunpoet@FreeBSD.org>
wrote:

> The branch main has been updated by sunpoet:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=4dc04ac964f8af7666478eff399814f102fb5eb1
> 
> commit 4dc04ac964f8af7666478eff399814f102fb5eb1
> 
> Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> 
> AuthorDate: 2024-02-21 14:27:22 +0000
> 
> Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> 
> CommitDate: 2024-02-21 15:06:37 +0000
> 
>     net/libngtcp2: Update to 1.3.0
> 
>     
> 
>     - Convert back to autotools
> 
>     - Remove unnecessary substitution
> 
>     
> 
>     Changes:        https://github.com/ngtcp2/ngtcp2/releases
> 
> ---
> 
>  net/libngtcp2/Makefile                | 17 ++++++++---------
> 
>  net/libngtcp2/distinfo                |  6 +++---
> 
>  net/libngtcp2/files/patch-Makefile.in [http://patch-Makefile.in] | 13 +++++++++++++
> 
>  net/libngtcp2/pkg-plist               |  2 +-
> 
>  4 files changed, 25 insertions(+), 13 deletions(-)
> 
> diff --git a/net/libngtcp2/Makefile b/net/libngtcp2/Makefile
> 
> index 1deb680168a1..215e17283363 100644
> 
> --- a/net/libngtcp2/Makefile
> 
> +++ b/net/libngtcp2/Makefile
> 
> @@ -1,7 +1,7 @@
> 
>  PORTNAME=    ngtcp2
> 
> -DISTVERSION=    1.2.0
> 
> +PORTVERSION=    1.3.0
> 
>  CATEGORIES=    net
> 
> -MASTER_SITES=    https://github.com/${PORTNAME}/${PORTNAME}/releases/download/v${DISTVERSION}/
> 
> +MASTER_SITES=    https://github.com/ngtcp2/ngtcp2/releases/download/v${PORTVERSION}/
> 
>  PKGNAMEPREFIX=    lib
> 
>  
> 
>  MAINTAINER=    sunpoet@FreeBSD.org
> 
> @@ -12,13 +12,12 @@ WWW=        https://nghttp2.org/ngtcp2/ \
> 
>  LICENSE=    MIT
> 
>  LICENSE_FILE=    ${WRKSRC}/COPYING
> 
>  
> 
> -USES=        cmake compiler:c++14-lang pathfix tar:xz
> 
> -USE_LDCONFIG=    yes
> 
> +USES=        compiler:c++14-lang libtool pathfix pkgconfig tar:xz
> 
>  
> 
> -# Always disabled due to lack of QUIC support which is in 3.2
> 
> -CMAKE_OFF=    ENABLE_OPENSSL
> 
> -CMAKE_ON=    CMAKE_DISABLE_FIND_PACKAGE_CUnit \
> 
> -        CMAKE_DISABLE_FIND_PACKAGE_Libev \
> 
> -        CMAKE_DISABLE_FIND_PACKAGE_Libnghttp3
> 
> +CONFIGURE_ARGS=    --enable-lib-only --with-jemalloc
> 
> +GNU_CONFIGURE=    yes
> 
> +INSTALL_TARGET=    install-strip
> 
> +USE_CXXSTD=    c++14
> 
> +USE_LDCONFIG=    yes
> 
>  
> 
>  .include <bsd.port.mk> [http://bsd.port.mk>];
> 
> diff --git a/net/libngtcp2/distinfo b/net/libngtcp2/distinfo
> 
> index 5e02e151e88b..5b049b4b98d5 100644
> 
> --- a/net/libngtcp2/distinfo
> 
> +++ b/net/libngtcp2/distinfo
> 
> @@ -1,3 +1,3 @@
> 
> -TIMESTAMP = 1705948404
> 
> -SHA256 (ngtcp2-1.2.0.tar.xz) = b0e78508bcf861296eb2382a845413ecb10b2f2209928e25eedab81680650a95
> 
> -SIZE (ngtcp2-1.2.0.tar.xz) = 598000
> 
> +TIMESTAMP = 1708448948
> 
> +SHA256 (ngtcp2-1.3.0.tar.xz) = c3e386674103feedfedcc711190affcdec1c682af8a850469ecf1714d28c139b
> 
> +SIZE (ngtcp2-1.3.0.tar.xz) = 615620
> 
> diff --git a/net/libngtcp2/files/patch-Makefile.in [http://patch-Makefile.in] b/net/libngtcp2/files/patch-Makefile.in [http://patch-Makefile.in]
> 
> new file mode 100644
> 
> index 000000000000..afad6594b328
> 
> --- /dev/null
> 
> +++ b/net/libngtcp2/files/patch-Makefile.in [http://patch-Makefile.in]
> 
> @@ -0,0 +1,13 @@
> 
> +--- Makefile.in.orig [http://Makefile.in.orig]    2022-01-16 12:35:06 UTC
> 
> ++++ Makefile.in [http://Makefile.in]
> 
> +@@ -425,8 +425,8 @@ top_srcdir = @top_srcdir@
> 
> + # LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
> 
> + # OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
> 
> + # WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
> 
> +-SUBDIRS = lib tests doc $(am__append_1) $(am__append_2)
> 
> +-dist_doc_DATA = README.rst
> 
> ++SUBDIRS = lib $(am__append_1)
> 
> ++dist_doc_DATA =
> 
> + ACLOCAL_AMFLAGS = -I m4
> 
> + EXTRA_DIST = \
> 
> +     cmakeconfig.h.in [http://cmakeconfig.h.in] \
> 
> diff --git a/net/libngtcp2/pkg-plist b/net/libngtcp2/pkg-plist
> 
> index 000b4a1f39b2..a36461f1b13f 100644
> 
> --- a/net/libngtcp2/pkg-plist
> 
> +++ b/net/libngtcp2/pkg-plist
> 
> @@ -3,5 +3,5 @@ include/ngtcp2/version.h
> 
>  lib/libngtcp2.a
> 
>  lib/libngtcp2.so [http://libngtcp2.so]
> 
>  lib/libngtcp2.so.16 [http://libngtcp2.so.16]
> 
> -lib/libngtcp2.so.16.1.1 [http://libngtcp2.so.16.1.1]
> 
> +lib/libngtcp2.so.16.1.2 [http://libngtcp2.so.16.1.2]
> 
>  libdata/pkgconfig/libngtcp2.pc

Hi,

Is there any reason for this change apart from adding unnecessary
patching (submit upstream) and slower builds which multiple people are
raised concerns about in general (see -ports mailing lists)?

Best regards,

Daniel