Re: git: 45b52cec21e6 - main - www/node18: Fix build with icu 76.1
- In reply to: Po-Chuan Hsieh : "git: 45b52cec21e6 - main - www/node18: Fix build with icu 76.1"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 31 Dec 2024 16:32:11 UTC
On Wed, Jan 1, 2025 at 12:06 AM Po-Chuan Hsieh <sunpoet@freebsd.org> wrote:
> The branch main has been updated by sunpoet:
>
> URL:
> https://cgit.FreeBSD.org/ports/commit/?id=45b52cec21e67673c5990eded07125f873839e55
>
> commit 45b52cec21e67673c5990eded07125f873839e55
> Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> AuthorDate: 2024-12-31 15:57:15 +0000
> Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> CommitDate: 2024-12-31 15:57:15 +0000
>
> www/node18: Fix build with icu 76.1
> PR: 283566
>
It should be:
www/node20: Fix build with icu 76.1
PR: 283567
Reported by: diizzy
> Obtained from:
> https://github.com/nodejs/node/commit/81517faceac86497b3c8717837f491aa29a5e0f9
> ---
> www/node20/files/patch-icu | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/www/node20/files/patch-icu b/www/node20/files/patch-icu
> new file mode 100644
> index 000000000000..13dbbdccc8fd
> --- /dev/null
> +++ b/www/node20/files/patch-icu
> @@ -0,0 +1,13 @@
> +Obtained from:
> https://github.com/nodejs/node/commit/81517faceac86497b3c8717837f491aa29a5e0f9
> +
> +--- configure.py.orig 2024-11-20 13:28:19 UTC
> ++++ configure.py
> +@@ -1829,7 +1829,7 @@ def configure_intl(o):
> + elif with_intl == 'system-icu':
> + # ICU from pkg-config.
> + o['variables']['v8_enable_i18n_support'] = 1
> +- pkgicu = pkg_config('icu-i18n')
> ++ pkgicu = pkg_config(['icu-i18n', 'icu-uc'])
> + if not pkgicu[0]:
> + error('''Could not load pkg-config data for "icu-i18n".
> + See above errors or the README.md.''')
>