Re: git: 3018b7a319e2 - main - multimedia/assimp: remove static library

Moin-moid!

Aaaaand! This brake consumers because .cmake files still refers a static library


For example, graphics/qt6-3d:

> CMake Error at /usr/local/lib/cmake/assimp-5.3/assimpTargets.cmake:88 (message):
>   The imported target "assimp::zlibstatic" references the file
> 
>      "/usr/local/lib/libzlibstatic.a"
> 
>   but this file does not exist.  Possible reasons include:
> 
>   * The file was deleted, renamed, or moved to another location.
> 
>   * An install or uninstall procedure did not complete successfully.
> 
>   * The installation package was faulty and contained
> 
>      "/usr/local/lib/cmake/assimp-5.3/assimpTargets.cmake"
> 
>   but not all the files it references.


Please fix it or revert.


On 29.10.2023 13:46, Piotr Kubaj wrote:
> The branch main has been updated by pkubaj:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=3018b7a319e228ce953bcda63d31c36f65eb1c3e
> 
> commit 3018b7a319e228ce953bcda63d31c36f65eb1c3e
> Author:     Piotr Kubaj <pkubaj@FreeBSD.org>
> AuthorDate: 2023-10-28 21:42:37 +0000
> Commit:     Piotr Kubaj <pkubaj@FreeBSD.org>
> CommitDate: 2023-10-29 10:44:38 +0000
> 
>      multimedia/assimp: remove static library
>      
>      PR:     274717
>      Approved by:    yuri@
> ---
>   multimedia/assimp/Makefile  | 3 ++-
>   multimedia/assimp/pkg-plist | 1 -
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/multimedia/assimp/Makefile b/multimedia/assimp/Makefile
> index 8fa28cb389bc..f0f5f20e0c76 100644
> --- a/multimedia/assimp/Makefile
> +++ b/multimedia/assimp/Makefile
> @@ -1,6 +1,7 @@
>   PORTNAME=	assimp
>   DISTVERSIONPREFIX=	v
>   DISTVERSION=	5.3.1
> +PORTREVISION=	1
>   CATEGORIES=	multimedia
>   
>   MAINTAINER=	yuri@FreeBSD.org
> @@ -17,7 +18,7 @@ USES=		cmake:testing compiler:c++17-lang cpe localbase:ldflags pkgconfig # miniz
>   USE_GITHUB=	yes
>   USE_LDCONFIG=	yes
>   
> -CMAKE_OFF=		ASSIMP_BUILD_TESTS
> +CMAKE_OFF=		ASSIMP_BUILD_TESTS BUILD_STATIC_LIBS
>   CMAKE_ON=		ASSIMP_BUILD_MINIZIP # workaround for https://github.com/assimp/assimp/issues/4374
>   CMAKE_TESTING_ON=	ASSIMP_BUILD_TESTS
>   CMAKE_TESTING_TARGET=	${ALL_TARGET} # hack to avoid target
> diff --git a/multimedia/assimp/pkg-plist b/multimedia/assimp/pkg-plist
> index 8d6d3a5fdeca..c96cdd0ce6fa 100644
> --- a/multimedia/assimp/pkg-plist
> +++ b/multimedia/assimp/pkg-plist
> @@ -94,5 +94,4 @@ lib/cmake/assimp-5.3/assimpTargets.cmake
>   lib/libassimp.so
>   lib/libassimp.so.5
>   lib/libassimp.so.5.3.0
> -lib/libzlibstatic.a
>   libdata/pkgconfig/assimp.pc
> 

-- 
Sincerely,
Dima (fluffy@FreeBSD.org, https://t.me/FluffyBSD)
(desktop, kde, x11, office, ports-secteam)@FreeBSD team