Re: git: 6e968aff79f9 - main - mail/fetchmail: Remove unneeded CA_BUNDLE option.

Am 06.10.23 um 11:07 schrieb Dag-Erling Smørgrav:
> The branch main has been updated by des:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=6e968aff79f98c52529e6b15720488bc05db7c83
> 
> commit 6e968aff79f98c52529e6b15720488bc05db7c83
> Author:     Dag-Erling Smørgrav <des@FreeBSD.org>
> AuthorDate: 2023-10-06 09:07:23 +0000
> Commit:     Dag-Erling Smørgrav <des@FreeBSD.org>
> CommitDate: 2023-10-06 09:07:23 +0000
> 
>      mail/fetchmail: Remove unneeded CA_BUNDLE option.
>      
>      MFH:            2023Q4
>      Approved by:    maintainer
>      Differential Revision:  https://reviews.freebsd.org/D42073
> ---
>   mail/fetchmail/Makefile | 9 +++------
>   1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/mail/fetchmail/Makefile b/mail/fetchmail/Makefile
> index 324ed11c7941..3ac359fc5da5 100644
> --- a/mail/fetchmail/Makefile
> +++ b/mail/fetchmail/Makefile
> @@ -1,6 +1,6 @@
>   PORTNAME?=	fetchmail
>   DISTVERSION=	6.4.37
> -PORTREVISION?=	0
> +PORTREVISION?=	1
>   CATEGORIES=	mail
>   # The next line is inherited by the fetchmailconf dependent port,
>   # do NOT replace fetchmail by ${PORTNAME}
> @@ -45,17 +45,14 @@ PORTDOCS=	FAQ FEATURES NEWS NOTES OLDNEWS README README.SSL \
>   		README.SSL-SERVER design-notes.html esrs-design-notes.html \
>   		fetchmail-FAQ.html fetchmail-features.html todo.html
>   
> -OPTIONS_DEFINE=		CA_BUNDLE DOCS NLS
> -OPTIONS_DEFAULT=	CA_BUNDLE GSSAPI_BASE OPENSSL
> +OPTIONS_DEFINE=		DOCS NLS
> +OPTIONS_DEFAULT=	GSSAPI_BASE OPENSSL

Dag-Erling,

please:

1. show evidence where the maintainer approved this change;

2. explain why it was not sufficient to just remove CA_BUNDLE from 
OPTIONS_DEFAULT, and how we make sure that the default trust anchors are 
still present.

I do not currently anything in ports/CHANGES or ports/UPDATING.

TIA.

Regards,
Matthias
-- 
Matthias Andree
FreeBSD ports committer