Re: git: d1266382c292 - main - benchmarks/unixbench: Remove custom optimization and clean up Makefile

Hi, have you test the build?

On Mon, Oct 02, 2023 at 07:50:17PM +0000, Daniel Engberg wrote:
> The branch main has been updated by diizzy:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=d1266382c292f5f6731f0e29591cabbbd13f9f93
> 
> commit d1266382c292f5f6731f0e29591cabbbd13f9f93
> Author:     Daniel Engberg <diizzy@FreeBSD.org>
> AuthorDate: 2023-09-30 21:32:02 +0000
> Commit:     Daniel Engberg <diizzy@FreeBSD.org>
> CommitDate: 2023-10-02 19:50:13 +0000
> 
>     benchmarks/unixbench: Remove custom optimization and clean up Makefile
>     
>     * Define LICENSE_FILE
>     * Use USES= localbase:ldflags helper
>     * Drop OPTIMIZED_CFLAGS
>     * Some changes to Makefile to improve readability
>     
>     PR:             272705
>     Reviewed by:    pizzamig (maintainer)
> ---
>  benchmarks/unixbench/Makefile | 21 +++++++++------------
>  1 file changed, 9 insertions(+), 12 deletions(-)
> 
> diff --git a/benchmarks/unixbench/Makefile b/benchmarks/unixbench/Makefile
> index 71b578e03425..4cfcae1b486d 100644
> --- a/benchmarks/unixbench/Makefile
> +++ b/benchmarks/unixbench/Makefile
> @@ -2,7 +2,7 @@ PORTNAME=	unixbench
>  DISTVERSIONPREFIX=	v
>  DISTVERSION=	5.1.3-51
>  DISTVERSIONSUFFIX=	-g6705203
> -PORTREVISION=	1
> +PORTREVISION=	2
>  CATEGORIES=	benchmarks
>  
>  MAINTAINER=	pizzamig@FreeBSD.org
> @@ -10,27 +10,24 @@ COMMENT=	BYTE magazine's Public Domain benchmark for UNIX
>  WWW=		https://github.com/kdlucas/byte-unixbench
>  
>  LICENSE=	GPLv2
> +LICENSE_FILE=	${WRKSRC}/LICENSE.txt
>  
>  RUN_DEPENDS=	x11perf:x11/x11perf
>  
> -USES=		gmake gl perl5 shebangfix xorg
> +USES=		gmake gl localbase:ldflags perl5 shebangfix xorg
> +USE_GL=		gl
> +SHEBANG_FILES=	Run pgms/gfx-x11
> +USE_XORG=	x11 xext
> +
>  USE_GITHUB=	yes
>  GH_ACCOUNT=	kdlucas
>  GH_PROJECT=	byte-unixbench
> +
>  WRKSRC_SUBDIR=	UnixBench
> -USE_GL=	gl
> -USE_XORG=	x11 xext
> -CFLAGS+=	-I${LOCALBASE}/include \
> -			-L${LOCALBASE}/lib
>  
> -OPTIONS_DEFINE=	OPTIMIZED_CFLAGS
> -OPTIONS_EXCLUDE_aarch64=	OPTIMIZED_CFLAGS
> -MAKE_ENV=	"UB_GCC_OPTIONS=-O3 -ffast-math -fomit-frame-pointer"
> -#march generates code that can be incompatibe with previous CPU generations
> -OPTIMIZED_CFLAGS_MAKE_ENV=	"UB_GCC_OPTIONS=-O3 -ffast-math -fomit-frame-pointer -march=native"
> +MAKE_ENV=	UB_GCC_OPTIONS=" "
>  
>  SUB_FILES=	unixbench
> -SHEBANG_FILES=	Run pgms/gfx-x11
>  
>  post-patch:
>  	${REINPLACE_CMD} -e 's/^CC=gcc/#CC=gcc/' ${WRKSRC}/Makefile

-- 
meta <meta@FreeBSD.org>