From nobody Mon Mar 06 19:55:01 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PVq6y6zyyz3wJ5j; Mon, 6 Mar 2023 19:55:06 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PVq6x6kQ1z4PkL; Mon, 6 Mar 2023 19:55:05 +0000 (UTC) (envelope-from mat@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678132505; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Y/N9iCFuLGOU87/iPhzpDYWc/YMuXY820JWZ5M1S7PA=; b=V31uw1joTMNYugenA0mONIraESdcy+ZAUq3gxuXaBdvMOcat0PBstnUvnfT2Tit324bagU Ir4OpZOqiEB4IQjnAEwddZrX3fo2UWy2hAtTXX5zdaAmrF3cbUSfraZ/k0ooFVPBjLfSjj UNod71hZylsFQZ+eJRRMA1i8+LL8DG9xOkcu+CB0YbWxxBKi+h0X/ismKDHA2STM8MF2I7 690C+m7wFltSiDLhA6PMJHY4xoDQCcDKnzDx0QuzquOp4n7CIwbwqGRCFiP0/05r3ni5no tUKRskN6SZeXxTxftSds5JMC/58dWryh5CeUluEtNRtqXsVszgGCxmjZadicfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678132505; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Y/N9iCFuLGOU87/iPhzpDYWc/YMuXY820JWZ5M1S7PA=; b=m4GJQlzBNuRLNfeK4zbiSYJPnFV9yKmUMTpYHkhczWdf8uSD4zfKjQY8Nopz0TgwHPkFbF Gu/QE3IvEiMTRwbeH8yN9KF4wbwhOYsf58MoSZlxbFrqH7p51jSk+cdFzZqDyIxxJHs8kq 7PZgr1kbFmIyL2ACpK89QfGky8rX81si+hYp0zJcK+AfJAvdnyzeG9/6u6TL3V+6j+bpVu 92Uee7FqL1MS4uto3Nzs5KQUZzySmb/TtkNO0d0jzIwbFqxXeTIbrw4FhpGJvkrBId2WZy DXJnpKt4hcoz48lUMojlOCG2AisBv086iDHK77kj978PaUkyebtSV4iWv0S13Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1678132505; a=rsa-sha256; cv=none; b=qeFpmKRL5TqhgaluaDCwq+bmOIU3oxV+3HYbr/miu9+6SHyC/IldNWG5nn/zceLfdw6rCW BacjqAilxZqs+JRFIpNFn5ubsAo75i3aaBsCbbGmf14oL4Q7iDElrd1OKXJm1ca0K714CF dfMS7ttsSLN8/vX37HD0mZ0Byd1IFWfzvsvlPB7Hbx8foZiXCFSN0BFuBEBc52ZF9zaRV4 52oO7SDO/12+phKAhhgOWpekevd1YsLeNQ/x/F4OdJH78y6AHbBDizwJ/tgyUNEUnUcy/k Ho1hvBqTvEMKCMtfN30enQvhZDo9XWmCRk678Qng4F2kdAoe/vBWVb/Xw64Rcg== Received: from mail.j.mat.cc (owncloud.cube.mat.cc [IPv6:2a01:678:4:1::228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail.mat.cc", Issuer "R3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PVq6x554kz1BNn; Mon, 6 Mar 2023 19:55:05 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (unknown [IPv6:2a01:e0a:836:f670:e4fe:745e:1d65:7cd6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id 728E3942D80; Mon, 6 Mar 2023 19:55:02 +0000 (UTC) Date: Mon, 6 Mar 2023 20:55:01 +0100 From: Mathieu Arnold To: Koichiro Iwao Cc: Alexey Dokuchaev , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: d69b20995dec - main - security/softether5: add DEBUG option Message-ID: <20230306195501.ithqt45oxm2z2mgn@aching.in.mat.cc> References: <202303060432.3264Wbtc041269@gitrepo.freebsd.org> <20230306142506.kckwmjxqgyv6usry@icepick.vmeta.jp> <20230306195254.n3gxqbchj5voyypw@aching.in.mat.cc> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vdcvekvbvaye234z" Content-Disposition: inline In-Reply-To: <20230306195254.n3gxqbchj5voyypw@aching.in.mat.cc> X-ThisMailContainsUnwantedMimeParts: N --vdcvekvbvaye234z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 06, 2023 at 08:52:54PM +0100, Mathieu Arnold wrote: > On Mon, Mar 06, 2023 at 11:25:06PM +0900, Koichiro Iwao wrote: > > On Mon, Mar 06, 2023 at 06:43:40AM +0000, Alexey Dokuchaev wrote: > > > On Mon, Mar 06, 2023 at 04:32:37AM +0000, Koichiro Iwao wrote: > > > > commit d69b20995dec38f96ef28522bc6156a7d5b80fff > > > >=20 > > > > security/softether5: add DEBUG option > > > >=20 > > > > [...] > > > > +.include > > > > + > > > > +# CMAKE_BUILD_TYPE is automatically set by Mk/Uses/cmake.mk > > > > +# just set WITH_DEBUG=3Dyes, CMAKE_ARGS+=3D-DCMAKE_BUILD_TYPE=3DDe= bug takes no effect. > > > > +.if ${PORT_OPTIONS:MDEBUG} > > > > +WITH_DEBUG=3D yes > > >=20 > > > We do not expose this via options. To build debug package, just > > > "make -DWITH_DEBUG", don't ask users to fiddle with options. > > >=20 > > > ./danfe > >=20 > > Really? What's the difference exposing ports vs not? >=20 > WITH_DEBUG is a global user facing knob, it must never be activated via > options. Sorry, bad wording, it must never be set in any Makefile, wether options, flavor, or whatever. It is not a port setting, that one sets in a Makefile, it is a user setting that one sets in make.conf. --=20 Mathieu Arnold --vdcvekvbvaye234z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmQGRRVfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb50swv9Er+cO3XECHsXHPLE9zpULdaToENyZwyQz2OODIQ47jysIN1wqx0UtRE1 3tFNhPkiqXDPvEFp4Q3DMikhX/eaMZ6QUYMULm+P/z/OJzwdsk9JsOicY3dyfNCF xeaa7IFudHc5TOHIxwZfWZlRzkutgVp9vsHGtCy4NxUtneMSABl43aXX3dMreSS5 EKgpS2bLxiFjh6qgpgE6f/CuTK2GPYOEuKQhH9m5fQcnvEitslYrOhMbRXllyO9J i6N17R/mPYyctb3E7rSwxKCZVI/7naOqMjxwEgBaFNN2VodQSA0dJ7s/K0PW0Hwn tZpFmoM1GZKTTPAUmRWfv0ObYj4RlAV16G5sqM4x9C5EKmr4THSY1DUAT3Tjy/gN AXnD1aCzwZjYL4Fl8XxIXjnj59p/hsFDtBxuGm1WwkPoAUMVWvyM+vB5Qm0M4kXq xKk+n9PAYE9NNK6BstRp8oZjdn01ArUPwCax5NmrRiVqsqjT5D4fZTwsk3JJg9sq r1oWt7LV =SiOE -----END PGP SIGNATURE----- --vdcvekvbvaye234z--