Re: git: 522d39ae76a1 - main - math/Imath: Fix GH_* usage

On Tue, Jun 6, 2023 at 3:07 AM Matthias Andree <mandree@freebsd.org> wrote:

> Am 05.06.23 um 21:01 schrieb Po-Chuan Hsieh:
> > The branch main has been updated by sunpoet:
> >
> > URL:
> https://cgit.FreeBSD.org/ports/commit/?id=522d39ae76a1d17440e529c80065250cedfd6224
> >
> > commit 522d39ae76a1d17440e529c80065250cedfd6224
> > Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> > AuthorDate: 2023-06-05 18:46:16 +0000
> > Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> > CommitDate: 2023-06-05 18:49:13 +0000
> >
> >      math/Imath: Fix GH_* usage
> >
> >      Approved by:    portmgr (blanket)
> > ---
> >   math/Imath/Makefile | 3 ++-
> >   math/Imath/distinfo | 6 +++---
> >   2 files changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/math/Imath/Makefile b/math/Imath/Makefile
> > index 9fa973911789..c2d5eea7d856 100644
> > --- a/math/Imath/Makefile
> > +++ b/math/Imath/Makefile
> > @@ -2,6 +2,7 @@
> >
> >   PORTNAME=   Imath
> >   PORTVERSION=        3.1.9
> > +DISTVERSIONPREFIX=   v
> >   PORTREVISION=       0
> >   CATEGORIES= math devel graphics
> >
> > @@ -14,7 +15,7 @@ LICENSE=    BSD3CLAUSE
> >   USES=               cmake compiler:c++14-lang pathfix pkgconfig
> >
> >   USE_GITHUB= yes
> > -GH_TUPLE=    AcademySoftwareFoundation:Imath:v${PORTVERSION}
> > +GH_ACCOUNT=  AcademySoftwareFoundation
> >   USE_LDCONFIG=       yes
> >
> >   CMAKE_ARGS+=        -DCMAKE_DEBUG_POSTFIX= \
>
> Hi Po-Chuan,
>
> Care to explain what there was to "fix"? It wasn't broken.
>
> Regards,
> Matthias
>
> --
> Matthias Andree
> FreeBSD ports committer
>

Hello Matthias,

GH_TUPLE is used for multiple distributions.
In this case:
- We use GH_{ACCOUNT,PROJECT,TAGNAME}.
- GH_PROJECT is the default.
- GH_TAGNAME is slightly different from PORTVERSION, therefore we
use DISTVERSIONPREFIX instead.

Regards,
sunpoet