From nobody Mon Jan 16 22:13:37 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NwmWl6Sv3z2sX9b for ; Mon, 16 Jan 2023 22:13:55 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NwmWl4GRQz48Wh for ; Mon, 16 Jan 2023 22:13:55 +0000 (UTC) (envelope-from adamw@adamw.org) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x535.google.com with SMTP id v6so42476964edd.6 for ; Mon, 16 Jan 2023 14:13:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamw-org.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=POZj7pcU1R5KwnF704A/4L3NqyT/JRU0uEOWuoAZoVg=; b=bmEYPNhEJirTCsxDxKce2gpO+JP1YmI9NdU8bdun66YP5VpYFK6+Eq3Z1OacfVge7U TsJ/hd26/PIzYmSdt15fU6k/AbMJWnQpJurFl630St2+e3/2L/Fi5hR3P2nYtIjSgUCB SkUYuVZaSAJQc/JDDCrosxpYPBzjiAWik2LCtD1hB+Cd8Nn5eLQhYfrtiR9e77hmXK7Y rVEask8de0YKrPivt5YK/iwDbrppv3Jd4Y71AKJutHTa4kMNmcj2N+0t/AiKJT5H58tb jHiScsmv8+h/SF6IIgBVhaFwI9sgr3Yh+Da63vZ1/unk26DBoszlvq8Omah49KOUVHMg 5fmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=POZj7pcU1R5KwnF704A/4L3NqyT/JRU0uEOWuoAZoVg=; b=3F36eqCN//vu4fv8JmayujRUDB4xfiArDpCIq5NB0EOjdKNSwU7FrpEhWazeA4OzHo lNPZEj1vuDjJdMQSs9lsD7NoLxILXnt1WqUFLxleb1qU/DOUaIU5n43d/q+HmwgKPW1N nE9s6Z1PXPTfSQ1IkDgphEnT7WoJbGTo9z6T3FIyG5ygWrtinFTrPxCc4N84WhHYH9np gdFGkc5iyTD/FOQhGGPF8axy8SqwbyM7ljsa6iiIxoHJ+hEuGSDyVi6PjEYVo418b4fn vXm44WMABU+wBf2H+nAZmkUTymJiT0tj2Ocsp9lRKCniZvHLI9p/Po3RIwtaCXv2Ob06 oJ/g== X-Gm-Message-State: AFqh2kpFbrguL2Oqf+R7VPXZavTW7cSQY2w0I1XAgRMZaxSFJ27yogd1 l2MQGhmQRMscMufesSpe6BPuG5+HepZCZSFxwMfXSAHN/RCsO8jp X-Google-Smtp-Source: AMrXdXtJorklZo2XwLL65/G84J3rD5rdTXCk81dC8Q1hkUXVKko/3MVrsCC+0BeZbyPr6vgvPBrqWpR/lTnsuI8L7Fg= X-Received: by 2002:a05:6402:20f:b0:49c:a68c:8b6b with SMTP id t15-20020a056402020f00b0049ca68c8b6bmr93093edv.84.1673907233490; Mon, 16 Jan 2023 14:13:53 -0800 (PST) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202301161248.30GCmHnK091914@gitrepo.freebsd.org> In-Reply-To: From: Adam Weinberger Date: Mon, 16 Jan 2023 15:13:37 -0700 Message-ID: Subject: Re: git: 38e6e935efa6 - main - dns/unbound: add dynlib port option To: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= , jaap@nlnetlabs.nl Cc: "ports-committers@FreeBSD.org" , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000000a1fdd05f268e629" X-Rspamd-Queue-Id: 4NwmWl4GRQz48Wh X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --0000000000000a1fdd05f268e629 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jan 16, 2023 at 2:12 PM Fernando Apestegu=C3=ADa wrote: > > > El lun., 16 ene. 2023 19:50, Adam Weinberger escribi=C3= =B3: > >> >> >> On Mon, Jan 16, 2023 at 5:48 AM Fernando Apestegu=C3=ADa >> wrote: >> >>> The branch main has been updated by fernape: >>> >>> URL: >>> https://cgit.FreeBSD.org/ports/commit/?id=3D38e6e935efa67110ba6d2d1e322= 555f0afbb8383 >>> >>> commit 38e6e935efa67110ba6d2d1e322555f0afbb8383 >>> Author: Fernando Apestegu=C3=ADa >>> AuthorDate: 2023-01-15 19:29:38 +0000 >>> Commit: Fernando Apestegu=C3=ADa >>> CommitDate: 2023-01-16 12:44:02 +0000 >>> >>> dns/unbound: add dynlib port option >>> >> >>> PR: 268942 >>> Reported by: me@rcm.sh >>> Approved by: jaap@NLnetLabs.nl (maintainer) >>> --- >>> dns/unbound/Makefile | 9 ++++++--- >>> 1 file changed, 6 insertions(+), 3 deletions(-) >>> >>> >> Does this need a pkg-plist change? If the plist is the same with this >> option on and off, what is this option actually controlling? >> > > The dynlib option is to build that module into the same daemon: > > > https://unbound.docs.nlnetlabs.nl/en/latest/manpages/unbound.conf.html#dy= namic-library-module-options > Ohhhh, so it's about loading *third-party* modules as shared libs? (Looping in maintainer here) If the previous statement is correct, would you be okay with me updating DYNLIB_DESC to reflect that? As it's currently written it looks like turning it off would create a fully statically-linked sbin/unbound, which is not the case. # Adam --=20 Adam Weinberger adamw@adamw.org https://www.adamw.org --0000000000000a1fdd05f268e629 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


<= div dir=3D"ltr" class=3D"gmail_attr">On Mon, Jan 16, 2023 at 2:12 PM Fernan= do Apestegu=C3=ADa <fernape@freeb= sd.org> wrote:


El lun., 16 ene. 2023 19:50, Adam Weinberger <= ;adamw@adamw.org&g= t; escribi=C3=B3:


On Mon, Jan 16, 2023 at 5:48 AM Fernando Apestegu=C3=ADa &l= t;fernape@freebsd.org> wrote:
The branch main has been updated by fernape:

URL: = https://cgit.FreeBSD.org/ports/commit/?id=3D38e6e935efa67110ba6d2d1e322555f= 0afbb8383

commit 38e6e935efa67110ba6d2d1e322555f0afbb8383
Author:=C2=A0 =C2=A0 =C2=A0Fernando Apestegu=C3=ADa <fernape@FreeBSD.org= >
AuthorDate: 2023-01-15 19:29:38 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Fernando Apestegu=C3=ADa <fernape@FreeBSD.org= >
CommitDate: 2023-01-16 12:44:02 +0000

=C2=A0 =C2=A0 dns/unbound: add dynlib port option

=C2=A0 =C2=A0 PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0268942
=C2=A0 =C2=A0 Reported by:=C2=A0 =C2=A0 me@rcm.sh
=C2=A0 =C2=A0 Approved by:=C2=A0 =C2=A0 jaap@NLnetLabs.nl (maintainer)
---
=C2=A0dns/unbound/Makefile | 9 ++++++---
=C2=A01 file changed, 6 insertions(+), 3 deletions(-)


Does this need a pkg-plist change? If the plist is the same with this opti= on on and off, what is this option actually controlling?
<= /blockquote>

The d= ynlib option is to build that module into the same daemon:


Ohhhh, so it's about loading *third-party* modules as sh= ared libs?

(Looping in maintainer here) If the previous statement is corre= ct, would you be okay with me updating DYNLIB_DESC to reflect that? As it&#= 39;s currently written it looks like turning it off would create a fully st= atically-linked sbin/unbound, which is not the case.

# Adam


--
--0000000000000a1fdd05f268e629--