git: ad4aca3c285b - main - textproc/jade: remove non-functional deoptimization
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Mon, 18 Dec 2023 19:15:27 UTC
The branch main has been updated by brooks:
URL: https://cgit.FreeBSD.org/ports/commit/?id=ad4aca3c285b5a106db490cc19fe750cba8a4380
commit ad4aca3c285b5a106db490cc19fe750cba8a4380
Author: Brooks Davis <brooks@FreeBSD.org>
AuthorDate: 2023-12-18 19:14:14 +0000
Commit: Brooks Davis <brooks@FreeBSD.org>
CommitDate: 2023-12-18 19:15:10 +0000
textproc/jade: remove non-functional deoptimization
Long ago, this code was added to disable -O2 optimizations and
presumably remove -mcpu flags to avoid miscompilation. Somewhere along
the line it stopped working and code is being compiled with -O2 by
default and proably with -mcpu flags if set. The only place this seems
to be used is when checking if the compiler works early in configure.
Discovered on CheriBSD where removing -m* removed created an invalid
command line with two -Xclang flags in a row.
Reviewed by: cy
Sponsored by: DARPA
Differential Revision: https://reviews.freebsd.org/D43072
---
textproc/jade/Makefile | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/textproc/jade/Makefile b/textproc/jade/Makefile
index e6cdf3da74b2..825dec1f1f68 100644
--- a/textproc/jade/Makefile
+++ b/textproc/jade/Makefile
@@ -45,9 +45,4 @@ post-install:
${MKDIR} ${STAGEDIR}${PREFIX}/share/xml/jade
${INSTALL_DATA} ${WRKSRC}/pubtext/xml* ${STAGEDIR}${PREFIX}/share/xml/jade
-.include <bsd.port.pre.mk>
-
-# Same problem with textproc/openjade.
-CPPFLAGS:= -O ${CFLAGS:N-O*:N-m*}
-
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>