git: 4cf63f596dd4 - main - devel/rvm: remove useless sbrk use
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Fri, 08 Dec 2023 23:30:57 UTC
The branch main has been updated by brooks:
URL: https://cgit.FreeBSD.org/ports/commit/?id=4cf63f596dd42bee1c83ae79e991813f8d3143af
commit 4cf63f596dd42bee1c83ae79e991813f8d3143af
Author: Brooks Davis <brooks@FreeBSD.org>
AuthorDate: 2023-12-06 19:13:02 +0000
Commit: Brooks Davis <brooks@FreeBSD.org>
CommitDate: 2023-12-08 23:24:16 +0000
devel/rvm: remove useless sbrk use
sbrk was used to in a function intended to be called from gdb in a test
script to produce informational output about heap use. At best this was
inaccurate and it's implausible that any port user ever used it.
---
devel/rvm/Makefile | 4 +---
devel/rvm/files/patch-tests_rvm__basher.c | 32 +++++++++++++++++++++++++++++++
2 files changed, 33 insertions(+), 3 deletions(-)
diff --git a/devel/rvm/Makefile b/devel/rvm/Makefile
index a3ae620c0f03..3ffe1921c457 100644
--- a/devel/rvm/Makefile
+++ b/devel/rvm/Makefile
@@ -1,5 +1,6 @@
PORTNAME= rvm
DISTVERSION= 1.20
+PORTREVISION= 1
CATEGORIES= devel
MASTER_SITES= http://ftp.coda.cs.cmu.edu/pub/rvm/src/ \
http://ftp.wu-wien.ac.at/pub/systems/coda/src/ \
@@ -13,9 +14,6 @@ WWW= http://www.coda.cs.cmu.edu/
LICENSE= GPLv2
LICENSE_FILE= ${WRKSRC}/COPYING
-BROKEN_aarch64= Fails to link: missing sbrk
-BROKEN_riscv64= Fails to link: missing sbrk
-
LIB_DEPENDS= liblwp.so:devel/lwp
USES= libtool pathfix pkgconfig
diff --git a/devel/rvm/files/patch-tests_rvm__basher.c b/devel/rvm/files/patch-tests_rvm__basher.c
new file mode 100644
index 000000000000..9fed5684cdd9
--- /dev/null
+++ b/devel/rvm/files/patch-tests_rvm__basher.c
@@ -0,0 +1,32 @@
+--- tests/rvm_basher.c.orig
++++ tests/rvm_basher.c
+@@ -1579,20 +1579,10 @@
+ /* print break point and limit */
+ static void show_break()
+ {
+- rvm_length_t cur_brk;
+ #ifdef RLIMIT_DATA
+ struct rlimit rlp;
+ #endif
+
+- /* get current break point */
+- errno = 0;
+- if ((cur_brk=(rvm_length_t)sbrk(0)) == -1)
+- {
+- printf("\n? Error getting current break point\n");
+- printf(" errno = %d\n",errno);
+- CODA_ASSERT(rvm_false);
+- }
+-
+ /* get system maximum */
+ errno = 0;
+ #ifdef RLIMIT_DATA
+@@ -1604,8 +1594,6 @@
+ }
+
+ /* print the limits */
+- printf("\nCurrent break point: 0x%lx\n",
+- RVM_ROUND_LENGTH_UP_TO_PAGE_SIZE(cur_brk+5*RVM_PAGE_SIZE));
+ printf("Maximum data segment length: 0x%lx\n\n",rlp.rlim_max);
+ #endif
+ exit(0);