Re: git: 62a1ed42b8ec - main - security/snort3: define TSC option everywhere to add it to PLIST_SUB

In reply to: Moin Rahman : "Re: git: 62a1ed42b8ec - main - security/snort3: define TSC option everywhere to add it to PLIST_SUB"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Piotr Kubaj <pkubaj_at_anongoth.pl>
Date: Thu, 22 Sep 2022 20:42:20 UTC

On 22-09-22 16:31:30, Moin Rahman wrote:
> This is not the solution.

1. It doesn't break amd64.
2. It allows to build on other architectures.

I consider it the most simple solution available. I don't insist it's the best one.
> 
> > On Sep 22, 2022, at 1:26 PM, Piotr Kubaj <pkubaj@FreeBSD.org> wrote:
> > 
> > The branch main has been updated by pkubaj:
> > 
> > URL: https://cgit.FreeBSD.org/ports/commit/?id=62a1ed42b8ec8c143472c8a1cd66d725afc5676a
> > 
> > commit 62a1ed42b8ec8c143472c8a1cd66d725afc5676a
> > Author:     Piotr Kubaj <pkubaj@FreeBSD.org>
> > AuthorDate: 2022-09-22 10:13:58 +0000
> > Commit:     Piotr Kubaj <pkubaj@FreeBSD.org>
> > CommitDate: 2022-09-22 10:13:58 +0000
> > 
> >    security/snort3: define TSC option everywhere to add it to PLIST_SUB
> > ---
> > security/snort3/Makefile | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/security/snort3/Makefile b/security/snort3/Makefile
> > index 97109a833092..f013114639c1 100644
> > --- a/security/snort3/Makefile
> > +++ b/security/snort3/Makefile
> > @@ -32,8 +32,7 @@ CMAKE_ARGS+=	-DFLEX_INCLUDE_DIR_HINT:PATH=${PREFIX}/include/flex
> > CONFLICTS=	snort-2*
> > 
> > OPTIONS_DEFINE=		ADDRESSSANITIZER DEBUG DOCS FLATBUFFERS HYPERSCAN \
> > -			LARGEPCAP PIE STATICDAQ THREADSANITIZER
> > -OPTIONS_DEFINE_amd64=	TSC
> > +			LARGEPCAP PIE STATICDAQ THREADSANITIZER TSC
> > OPTIONS_DEFAULT=	STATICDAQ
> > OPTIONS_DEFAULT_amd64=	HYPERSCAN
> > OPTIONS_SUB=		yes
>