From nobody Tue Sep 13 04:29:08 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MRVps0pB8z4cM8M; Tue, 13 Sep 2022 04:29:09 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MRVpr2x01z4N1t; Tue, 13 Sep 2022 04:29:08 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1663043348; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LtVEplTLPCXldmS0CWnyBSWqyg4S509MpvtJx/n66D0=; b=IH9u6wx9F0TsqPgCmzoYrnIBSo8dHwdRO/2YRid5g7OjdLkX+aPopCmk9m9AA/NXoN/x9x z0HxdVYq8w6cz/5d+0QPMMTyBArfn/NTwSlrgE+699sMzGg3jr6k+9kJ1vWa/47U+ZrYLg t3dmxWhBoU3m7K6iry4i0Z06IVIbfYcGY0QgKiC3A9eprA6rHgnVeBts7ukCzJjpQzFcUA VO+BW88D6a8/Is43We23xQEzStQMj/AHrApDe/6xf0R0E2dHdVXbUKUVW/HI6M98Dxy8R4 6H6ubv/I49RvGvr9rhLKMWBrdAgpUMbIB73LkxwwlfP71oCr4yUnvH0GIk9qMQ== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 4282F4811; Tue, 13 Sep 2022 04:29:08 +0000 (UTC) Date: Tue, 13 Sep 2022 04:29:08 +0000 From: Alexey Dokuchaev To: Romain Tarti?re Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 97b0bb60dc4d - main - textproc/opensearch: Revert "Switch to a static pkg-plist" Message-ID: References: <202209112102.28BL2d1O026370@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1663043348; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LtVEplTLPCXldmS0CWnyBSWqyg4S509MpvtJx/n66D0=; b=RHVDi4yDKULu71fg0eZmTx5BS2uKh5PkZrohF9ABLju9yRkTf2wDCZDLT3ivmWWMA49+/J G87K7IXsOCxOcGBFrjl9/KwA+6xa/HLEJk0S7jeKGGMl8Szv/j2sNFAopp+ncX3yqqgM1F vGRxNZdjDIOP7/ogC+6N7REKbasEo4dfTiKXMEDzYLaV867pYpc3gBPhpD0XSPb/cpf/ax eYThL6LYhGG+OU5nFTTluKmWI5w1H6RRIESUmMaIYeg4IGqJurEGX3+sYW8wMPxzbfo5xN WxB0m566fpzoHCOkjZWUdy2uF4GaNMD3CPjiA24V8FYsr0jcODYxMTQkbcjPIQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1663043348; a=rsa-sha256; cv=none; b=XkeUJQe7G4U3WJpeHlbMKichNyfAG+ZSXZAcXGOyCPGRWSWDGG7wJ2QAjYfWuTNQrd8Wg9 xZS5CFNdonRdA658CzNRLD9hOP2mtQV0+gEQtWwYtFbxP0dJ5iELs0RbvOi5vqP1iTKWFg mm8443X5FwH7iKHo/eCJoKyxdRlVBZMzlv4jVVxgKyjNcpCkgNbYfQoc9L+pAdOpAa2Fzc lNngrsjSDhM8rf2IDKCV2qY1C5ZWyfjB6Gnbrlxa/ty7t86vFvpnHBQB0OCi6DW4SC1C6+ gJtwpi1hSPJ7kppI0BDAFaDv4u7ej05AZbK6hcSX9SrnCcUd3DfBSJpqoweAYQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Mon, Sep 12, 2022 at 03:28:47PM -1000, Romain Tarti?re wrote: > On Mon, Sep 12, 2022 at 04:27:13AM +0000, Alexey Dokuchaev wrote: > > On Sun, Sep 11, 2022 at 09:02:39PM +0000, Romain Tarti??re wrote: > > > commit 97b0bb60dc4dc6a71a26e08cc3d92576067b017a > > > > > > textproc/opensearch: Revert "Switch to a static pkg-plist" > > > > > > This reverts commit 43c14b71d3e7212d18e14b44911abffc99f40c9b. > > > > Replying to a random backout commit with "this reverts commit $sha1" > > commit log: are they being performed automatically? Why they's never > > a sensible commit message which would explain the reasons for revert? > > Not sure I can help, but I can write the story of this commit: > > I was unsure about the changes in > 43c14b71d3e7212d18e14b44911abffc99f40c9b that's the reason why these > changes where in a specific commit, and I noted the reason for this in > the PR that suggested the change: > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265704#c6 Okay, so it's about lots of embedded version numbers in *.jar files which pollute the pkg-plist and you fear that subsequent updates would add some extra churn you'd rather avoid. > I also assume some tooling might exist and help you navigate easily in > history, and they might be mislead by altered revert commit messages > (the reason why I was not happy with amending the commit). Navigating the history is not exactly what I'm concerned about. :-) > So this is the reason _I_ keep the generated commit message and don't > replace it with something more descriptive like "textproc/opensearch: > Revert back to dynamic plist". It is not more descriptive at all as it is still missing the particular reason for the backout. Regardless of your workflow and tangos you dance with git, commit logs should not just describe *what* had been changed, but more importantly, *why*. ./danfe