Re: git: ddd0e820c8eb - main - Mk/bsd.ports.mk: Add suppport for WWW in Makefiles

From: Antoine Brodin <antoine_at_freebsd.org>
Date: Fri, 09 Sep 2022 06:40:13 UTC
On Wed, Sep 7, 2022 at 7:41 PM Stefan Eßer <se@freebsd.org> wrote:
>
> The branch main has been updated by se:
>
> URL: https://cgit.FreeBSD.org/ports/commit/?id=ddd0e820c8eb73acef94c72434c382982d0fa329
>
> commit ddd0e820c8eb73acef94c72434c382982d0fa329
> Author:     Stefan Eßer <se@FreeBSD.org>
> AuthorDate: 2022-09-07 19:32:54 +0000
> Commit:     Stefan Eßer <se@FreeBSD.org>
> CommitDate: 2022-09-07 19:32:54 +0000
>
>     Mk/bsd.ports.mk: Add suppport for WWW in Makefiles
>
>     Expect the project website or other relevant URL of a port to be
>     specified in a WWW macro in its Makefile.
>
>     This information used to be available in WWW: lines at the end of
>     each port's pkg-descr file. By moving it into the Makefile, this
>     value is easier to access, verify, and maintain.
>
>     A WWW: line is added to the "desc" element of package manifests
>     based on the WWW macro value by the create-manifest.sh script.
>     This restores the previous contents of this line in the manifest
>     (as e.g. expected by the Freshports website).
>
>     The ports-mgmt/portlint port has been updated in commit 9800743f0
>     (version 2.19.13) to support the planned introduction of WWW in
>     port Makefiles.
>
>     Approved by:            portmgr (tcberner)
>     Differential Revision:  https://reviews.freebsd.org/D36434
> ---
>  Mk/Scripts/create-manifest.sh |  4 ++++
>  Mk/bsd.port.mk                | 43 +++++++++++++++----------------------------
>  2 files changed, 19 insertions(+), 28 deletions(-)
...
> @@ -4349,6 +4351,7 @@ _FETCH_DEPENDS=${FETCH_DEPENDS:C/^[^ :]+:([^ :@]+)(@[^ :]+)?(:[^ :]+)?/\1/:O:u:C
>  _LIB_DEPENDS=${LIB_DEPENDS:C/^[^ :]+:([^ :@]+)(@[^ :]+)?(:[^ :]+)?/\1/:O:u:C,(^[^/]),${PORTSDIR}/\1,}
>  _BUILD_DEPENDS=${BUILD_DEPENDS:C/^[^ :]+:([^ :@]+)(@[^ :]+)?(:[^ :]+)?/\1/:O:u:C,(^[^/]),${PORTSDIR}/\1,} ${_LIB_DEPENDS}
>  _RUN_DEPENDS=${RUN_DEPENDS:C/^[^ :]+:([^ :@]+)(@[^ :]+)?(:[^ :]+)?/\1/:O:u:C,(^[^/]),${PORTSDIR}/\1,} ${_LIB_DEPENDS}
> +_WWW=${WWW:U${MASTER_SITES:[1]}}
>  .      if exists(${DESCR})
>  _DESCR=${DESCR}
>  .      else

Hi,

Another regression,  now some ports fail because the manifest is not valid.
For instance:  http://gohan03.nyi.freebsd.org/data/main-amd64-default-baseline/p3af3d0f1a1c9_s1494f4776a/logs/errors/linux_base-c7-7.9.2009.log

Antoine