Re: git: c51ce87a4ef5 - main - editors/vim-colorschemes-legacy: Add port

On Mon, Sep 5, 2022 at 6:00 PM Cy Schubert <Cy.Schubert@cschubert.com>
wrote:

> In message <202209031633.283GXB0x034705@gitrepo.freebsd.org>, Adam
> Weinberger w
> rites:
> > The branch main has been updated by adamw:
> >
> > URL:
> https://cgit.FreeBSD.org/ports/commit/?id=c51ce87a4ef535f7df2c31bbf8b1cb
> > d1a0f1d579
> >
> > commit c51ce87a4ef535f7df2c31bbf8b1cbd1a0f1d579
> > Author:     Adam Weinberger <adamw@FreeBSD.org>
> > AuthorDate: 2022-09-03 16:26:48 +0000
> > Commit:     Adam Weinberger <adamw@FreeBSD.org>
> > CommitDate: 2022-09-03 16:26:48 +0000
> >
> >     editors/vim-colorschemes-legacy: Add port
> >
> >     Upstream vim modernized their colorschemes, which is a good thing.
> >     However, the look of them has changed, which is jarring at best for
> >     users used to the original look.
> >
> >     Upstream colorscheme development was split into a new repo, and the
> >     original colorschemes were imported there. This port installs those
> >     colorschemes.
> >
> >     The rest of that repo are the colorschemes included in vim, so
> there's
> >     not really any benefit to packaging anything else from it.
> >
> >     PR:             265798
> > ---
> >  editors/Makefile                              |  1 +
> >  editors/vim-colorschemes-legacy/Makefile      | 33 ++++++++++++
> >  editors/vim-colorschemes-legacy/distinfo      |  3 ++
> >  editors/vim-colorschemes-legacy/files/LICENSE | 78
> +++++++++++++++++++++++++
> > ++
> >  editors/vim-colorschemes-legacy/pkg-descr     |  7 +++
> >  editors/vim-colorschemes-legacy/pkg-plist     | 17 ++++++
> >  6 files changed, 139 insertions(+)
> >
> > diff --git a/editors/Makefile b/editors/Makefile
> > index 2a49e4899e93..2f7ab5ece415 100644
> > --- a/editors/Makefile
> > +++ b/editors/Makefile
> > @@ -268,6 +268,7 @@
> >      SUBDIR += vigor
> >      SUBDIR += vile
> >      SUBDIR += vim
> > +    SUBDIR += vim-colorschemes-legacy
> >      SUBDIR += vscode
> >      SUBDIR += web-mode
> >      SUBDIR += with-editor
> > diff --git a/editors/vim-colorschemes-legacy/Makefile
> b/editors/vim-colorsche
> > mes-legacy/Makefile
> > new file mode 100644
> > index 000000000000..b5c1ad467ada
> > --- /dev/null
> > +++ b/editors/vim-colorschemes-legacy/Makefile
> > @@ -0,0 +1,33 @@
> > +PORTNAME=    vim-colorschemes-legacy
> > +DISTVERSION= g20220816
> > +CATEGORIES=  editors
> > +
> > +MAINTAINER=  michael.osipov@siemens.com
> > +COMMENT=     Legacy colorschemes for Vim
> > +
> > +LICENSE=     VIM
> > +LICENSE_NAME=        VIM License
> > +LICENSE_FILE=        ${FILESDIR}/LICENSE
> > +LICENSE_PERMS=       dist-mirror dist-sell pkg-mirror pkg-sell
> auto-accept
> > +
> > +RUN_DEPENDS= vim:editors/vim
>
> Those who install vim-gtk* or vim-motif will notice that pkg install will
> uninstall the GUI version of vim and install vim-console.
>

Good catch, Cy.

This port doesn't actually depend on Vim and is usable by all Vim flavors
(and neovim!). It does need a Vim parser of some sort to do any good, but
even things like vimpager and nvimpager can use it.

Michael, I'd suggest removing the RUN_DEPENDS entirely. Also, reading up on
it more, this should probably go into LOCALBASE/vim/vimfiles/colors/legacy
rather than in Vim's (private) runtime library path. You good with those
two changes?

# Adam


-- 
Adam Weinberger
adamw@adamw.org // adamw@FreeBSD.org
https://www.adamw.org