Re: git: 9d241a90370c - main - Mk: Add USES=luajit

From: Adam Weinberger <adamw_at_freebsd.org>
Date: Fri, 14 Oct 2022 19:17:25 UTC
On Fri, Oct 14, 2022 at 12:33 PM Jan Beich <jbeich@freebsd.org> wrote:

> Adam Weinberger <adamw@freebsd.org> writes:
>
> > On Fri, Oct 14, 2022 at 11:25 AM Jan Beich <jbeich@freebsd.org> wrote:
> >
> >> Adam Weinberger <adamw@FreeBSD.org> writes:
> >>
> >> >     For the vast majority of situations, USES=luajit will be
> sufficient.
> >> >     Ports that use openresty's API additions can specify
> >> >     USES=luajit:openresty.
> >>
> >> Are consumers to be switched "en masse" or "one by one"?
> >>
> >
> > Hi Jan,
> >
> > I'm going to switch a couple ports (neovim and luv) right now, but my
> > thinking is that perhaps the best approach is two exp-runs. The first run
> > can switch everything depending on lang/luajit to USES=luajit. For the
> > second run, I'll need to look at everything that depends on
> > luajit-openresty to find out whether it uses it because it uses the
> > openresty API or because what they actually wanted was "anything other
> than
> > the old version in lang/luajit."
> >
> > Does that sound sensible?
>
> Probably:
> - exp-runs can be reduced via local testing as USES=luajit only has ~50
> candidates
> - luajit -> luajit-devel is safe due to same upstream and tested by other
> distros
> - luajit-openresty -> luajit-devel build test may show false negatives[1]
> but
>   ARCH-specific cases are likely safe
>
> [1] www/openresty and {devel,www}/lua-resty-* build fine with
> lang/luajit-devel.
>     However, not every instance maybe as obvious whether to ask maintainer.
>

Everything you said sounds very sensible. It sounds more like one-by-one
conversion makes the most sense. I could really use help on that if anyone
has the time. I don't have a great development machine that I can use to
test stuff, so if anybody wants to help with converting it'd be a big help.

# Adam


-- 
Adam Weinberger
adamw@adamw.org // adamw@FreeBSD.org
https://www.adamw.org