git: db2b8e7e56e0 - main - net/netatalk3: Fix metadata deletion warnings

The branch main has been updated by marcus:

URL: https://cgit.FreeBSD.org/ports/commit/?id=db2b8e7e56e03df0101eadbb86360c282e9494fd

commit db2b8e7e56e03df0101eadbb86360c282e9494fd
Author:     Joe Marcus Clarke <marcus@FreeBSD.org>
AuthorDate: 2022-10-13 17:12:35 +0000
Commit:     Joe Marcus Clarke <marcus@FreeBSD.org>
CommitDate: 2022-10-13 17:12:35 +0000

    net/netatalk3: Fix metadata deletion warnings
    
    These hunks should have been committed in the _3 update but were left
    out likely in some makepatch shuffling.
    
    PR:             267024
    Obtained from:  Upstream netatalk GitHub
---
 net/netatalk3/Makefile                             |  2 +-
 .../files/patch-libatalk_adouble_ad__open.c        | 62 ++++++++++++++++++++++
 2 files changed, 63 insertions(+), 1 deletion(-)

diff --git a/net/netatalk3/Makefile b/net/netatalk3/Makefile
index 71d081b6c62c..659a299aa0c1 100644
--- a/net/netatalk3/Makefile
+++ b/net/netatalk3/Makefile
@@ -1,6 +1,6 @@
 PORTNAME=	netatalk
 PORTVERSION=	3.1.13
-PORTREVISION=	3
+PORTREVISION=	4
 PORTEPOCH=	1
 CATEGORIES=	net
 MASTER_SITES=	SF
diff --git a/net/netatalk3/files/patch-libatalk_adouble_ad__open.c b/net/netatalk3/files/patch-libatalk_adouble_ad__open.c
index a5a279834158..bff592c563bd 100644
--- a/net/netatalk3/files/patch-libatalk_adouble_ad__open.c
+++ b/net/netatalk3/files/patch-libatalk_adouble_ad__open.c
@@ -95,3 +95,65 @@
              || ((eid != ADEID_RFORK) && (off + len >  valid_data_len)))
          {
              LOG(log_warning, logtype_ad, "parse_entries: bogus eid: %u, off: %u, len: %u",
+@@ -782,20 +791,42 @@ static int ad_header_read_ea(const char *path, struct 
+         EC_FAIL;
+     }
+ 
++    /*
++     * It is possible for AFP metadata to contain a zero-length
++     * comment. This will cause ad_entry(ad, ADEID_COMMENT) to return NULL
++     * but should not be treated as an error condition.
++     * Since recent CVE fixes have introduced new behavior regarding
++     * ad_entry() output. For now, we will AFP_ASSERT() in EC_CLEANUP to prevent
++     * altering on-disk info. This does introduce an avenue to DOS
++     * the netatalk server by locally writing garbage to the EA. At this
++     * point, the outcome is an acceptable risk to prevent unintended
++     * changes to metadata.
++     */
+     if (nentries != ADEID_NUM_EA
+         || !ad_entry(ad, ADEID_FINDERI)
+-        || !ad_entry(ad, ADEID_COMMENT)
+         || !ad_entry(ad, ADEID_FILEDATESI)
+         || !ad_entry(ad, ADEID_AFPFILEI)
+         || !ad_entry(ad, ADEID_PRIVDEV)
+         || !ad_entry(ad, ADEID_PRIVINO)
+         || !ad_entry(ad, ADEID_PRIVSYN)
+         || !ad_entry(ad, ADEID_PRIVID)) {
+-        LOG(log_error, logtype_ad, "ad_header_read_ea(\"%s\"): invalid metadata EA", fullpathname(path));
++        LOG(log_error, logtype_ad,
++            "ad_header_read_ea(\"%s\"): invalid metadata EA "
++            "this is now being treated as a fatal error. "
++            "if you see this log entry, please file a bug ticket "
++            "with your upstream vendor and attach the generated "
++            "core file.", path ? fullpathname(path) : "UNKNOWN");
++
+         errno = EINVAL;
+         EC_FAIL;
+     }
+ 
++    if (!ad_entry(ad, ADEID_COMMENT) &&
++        (ad->ad_eid[ADEID_COMMENT].ade_len != 0)) {
++        errno = EINVAL;
++        EC_FAIL;
++    }
++
+     /*
+      * Ensure the resource fork offset is always set
+      */
+@@ -805,6 +836,8 @@ static int ad_header_read_ea(const char *path, struct 
+ #endif
+ 
+ EC_CLEANUP:
++    AFP_ASSERT(!(ret != 0 && errno == EINVAL));
++#if 0
+     if (ret != 0 && errno == EINVAL) {
+         become_root();
+         (void)sys_removexattr(path, AD_EA_META);
+@@ -812,6 +845,7 @@ EC_CLEANUP:
+         LOG(log_error, logtype_ad, "ad_header_read_ea(\"%s\"): deleted invalid metadata EA", fullpathname(path), nentries);
+         errno = ENOENT;
+     }
++#endif
+     EC_EXIT;
+ }
+