Re: git: 03ff10027e28 - main - audio/libcanberra: split a gtk2 from non graphic port
Date: Fri, 20 May 2022 16:39:53 UTC
On Thu, 19 May 2022 12:34:07 GMT Baptiste Daroussin <bapt@FreeBSD.org>
wrote:
> The branch main has been updated by bapt:
>
> URL: https://cgit.FreeBSD.org/ports/commit/?id=03ff10027e28f1047a3057b5c3615a9a4d324276
>
> commit 03ff10027e28f1047a3057b5c3615a9a4d324276
> Author: Baptiste Daroussin <bapt@FreeBSD.org>
> AuthorDate: 2022-05-19 12:30:01 +0000
> Commit: Baptiste Daroussin <bapt@FreeBSD.org>
> CommitDate: 2022-05-19 12:34:03 +0000
>
> audio/libcanberra: split a gtk2 from non graphic port
>
> there was already a slave port for gtk3, now make a slaveport for gtk2 as
> well.
>
> While here fix the option definition which was wrongly done making libcanberra
> have no options at all while libcanberra-gtk3 had and the opposite was expected
>
> Use options helpers to simplify the port.
> Drop the gtkdoc by default
> bump revision and track no package for the 2 only port requiring the gtk2 library
> Reduce the slave port to its bare minimal requirement
>
> This change has been made in a slaveport instead of a flavor, because flavors depending
> on its own origin is not supported. this is a candidate for subpackages in the futur.
>
> note that this changes also removes gtk2 from the dependency path of many gtk3 only
> application
> ---
> audio/Makefile | 1 +
> audio/libcanberra-gtk2/Makefile | 7 ++++
> audio/libcanberra-gtk3/Makefile | 25 +-------------
> audio/libcanberra-gtk3/pkg-plist | 6 ----
> audio/libcanberra/Makefile | 52 ++++++++++++++--------------
> audio/libcanberra/pkg-plist | 64 ++++++++++++++++-------------------
> games/gnubg/Makefile | 4 +--
> mail/claws-mail-notification/Makefile | 4 +--
> 8 files changed, 67 insertions(+), 96 deletions(-)
>
> diff --git a/audio/libcanberra/Makefile b/audio/libcanberra/Makefile
> index 76b99d7bbe9d..4f2d3d9262a9 100644
> --- a/audio/libcanberra/Makefile
> +++ b/audio/libcanberra/Makefile
> @@ -3,7 +3,7 @@
>
> PORTNAME= libcanberra
> PORTVERSION= 0.30
> -PORTREVISION= 5
> +PORTREVISION= 6
> CATEGORIES= audio devel
> MASTER_SITES= http://0pointer.de/lennart/projects/libcanberra/ \
> http://pkgs.fedoraproject.org/repo/pkgs/libcanberra/libcanberra-0.30.tar.xz/34cb7e4430afaf6f447c4ebdb9b42072/
> @@ -17,47 +17,45 @@ LICENSE_FILE= ${WRKSRC}/LGPL
> LIB_DEPENDS= libvorbisfile.so:audio/libvorbis \
> libltdl.so:devel/libltdl
>
> -USES= gmake gnome libtool pathfix pkgconfig tar:xz
> +USES= gmake gnome localbase libtool pathfix pkgconfig tar:xz
> USE_GNOME= gnomeprefix gtk20
Should this USE_GNOME be removed?