From nobody Wed May 04 15:31:30 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 10D6D1AB53F5; Wed, 4 May 2022 15:31:33 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ktgm43SmYz3vVF; Wed, 4 May 2022 15:31:32 +0000 (UTC) (envelope-from manu@bidouilliste.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1651678290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iyU9d74hr4xDvkKhDm9/nG22A+H1le0BqsHSnMl6CLA=; b=iU9NfpxxgjY8c8mh/02XdIZBGw5BxP03BJdCDtOd2eivqFzqaZ3nssFRcAoxLVIu3D3pEZ SNLIJt3nLjUqhbcNKBX+7ikrMaATMvOFj933GXZjNd3kkkh5f1DzaEUeebSiAV2m+D3u87 AcohzC3hLDDCOCfWMAmQ3Fx8GrdFh8U= Received: from amy (lfbn-idf2-1-1209-45.w90-92.abo.wanadoo.fr [90.92.34.45]) by mx.blih.net (OpenSMTPD) with ESMTPSA id 18ec081a (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 4 May 2022 15:31:30 +0000 (UTC) Date: Wed, 4 May 2022 17:31:30 +0200 From: Emmanuel Vadot To: Piotr Kubaj Cc: Baptiste Daroussin , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: ecf09fe34600 - main - graphics/gpu-firmware*-kmod: disable amdgpu on powerpc64 Message-Id: <20220504173130.c60189dca479eae10d42bdca@bidouilliste.com> In-Reply-To: References: <202205041257.244CvQYJ029723@gitrepo.freebsd.org> <20220504152200.5881461e1e927b155884fe4c@bidouilliste.com> <20220504151604.dxems72xwxhj3eig@aniel.nours.eu> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4Ktgm43SmYz3vVF X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Wed, 4 May 2022 17:30:13 +0200 Piotr Kubaj wrote: > On 22-05-04 17:16:04, Baptiste Daroussin wrote: > > On Wed, May 04, 2022 at 04:32:59PM +0200, Piotr Kubaj wrote: > > > On 22-05-04 15:22:00, Emmanuel Vadot wrote: > > > > On Wed, 4 May 2022 12:57:26 GMT > > > > Piotr Kubaj wrote: > > > > > > > > > The branch main has been updated by pkubaj: > > > > > > > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=ecf09fe3460067b442ba41a6adb85897c99442b5 > > > > > > > > > > commit ecf09fe3460067b442ba41a6adb85897c99442b5 > > > > > Author: Piotr Kubaj > > > > > AuthorDate: 2022-05-04 12:54:19 +0000 > > > > > Commit: Piotr Kubaj > > > > > CommitDate: 2022-05-04 12:54:19 +0000 > > > > > > > > > > graphics/gpu-firmware*-kmod: disable amdgpu on powerpc64 > > > > > > > > > > amdgpu has known endianness issues and doesn't work on powerpc64. > > > > > radeonkms works, while amdgpu works on powerpc64le. > > > > > --- > > > > > graphics/gpu-firmware-amd-kmod/Makefile | 4 +- > > > > > graphics/gpu-firmware-kmod/Makefile | 67 +++++++++++++++++---------------- > > > > > 2 files changed, 37 insertions(+), 34 deletions(-) > > > > > > > > > > > > > Can you respect MAINTAINER and open a review next time ? > > > > > > I believe this falls under tier 2 blanket. Correct me if I'm mistaken. > > > > It somehow is and somehow isn't, basically the blanket for tier 2 is to commit > > trivial changes which allows a port to work (or be flagged as not working on a > > given architecture) exactly the same as the "just fix it blanket". > > > > Intrusive changes should anyway be discussed with the maintainer, and yes it is > > almost impossible to document what is intrusive from what is not, we have to > > rely on common sense here, and if one has a doubt, it is cheap to send a mail, > > open a PR, open a review to the maintainer anyway. > > > > The change here does not "fix" anything, so in my opinion, seeking for review > > and opening a discussion with the maintainer would have been a good idea. > > > > As for whether your change is a good idea or not, I will let you discuss that > > with the maintainer. > > > > Best regards, > > Bapt > > OK, then if you want me to revert that commit, I can do it. No need for revert. > Just note that graphics/gpu-firmware-kmod/Makefile already contained > architecture conditional for intel. And sending a mail/PR/review wouldn't have cost you a lot for this patch, I just ask that you do that next time. Cheers, -- Emmanuel Vadot