From nobody Wed May 04 15:30:13 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 98D511AB45AE; Wed, 4 May 2022 15:30:18 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from mail.anongoth.pl (mail.anongoth.pl [46.248.190.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X448 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "anongoth.pl", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ktgkc5hVkz3tsn; Wed, 4 May 2022 15:30:16 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from anongoth.pl (unknown [192.168.1.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: pkubaj@anongoth.pl) by mail.anongoth.pl (Postfix) with ESMTPSA id 7DE3318C163; Wed, 4 May 2022 17:30:14 +0200 (CEST) Date: Wed, 4 May 2022 17:30:13 +0200 From: Piotr Kubaj To: Baptiste Daroussin Cc: Emmanuel Vadot , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: ecf09fe34600 - main - graphics/gpu-firmware*-kmod: disable amdgpu on powerpc64 Message-ID: References: <202205041257.244CvQYJ029723@gitrepo.freebsd.org> <20220504152200.5881461e1e927b155884fe4c@bidouilliste.com> <20220504151604.dxems72xwxhj3eig@aniel.nours.eu> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Cnx07BzOhAcsa1xr" Content-Disposition: inline In-Reply-To: <20220504151604.dxems72xwxhj3eig@aniel.nours.eu> X-Rspamd-Queue-Id: 4Ktgkc5hVkz3tsn X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=pass (policy=reject) header.from=anongoth.pl; spf=pass (mx1.freebsd.org: domain of pkubaj@anongoth.pl designates 46.248.190.61 as permitted sender) smtp.mailfrom=pkubaj@anongoth.pl X-Spamd-Result: default: False [-5.29 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; FREEFALL_USER(0.00)[pkubaj]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:46.248.190.61]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; MID_RHS_NOT_FQDN(0.50)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.89)[-0.891]; DMARC_POLICY_ALLOW(-0.50)[anongoth.pl,reject]; MLMMJ_DEST(0.00)[dev-commits-ports-all,dev-commits-ports-main]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:47544, ipnet:46.248.160.0/19, country:PL]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N --Cnx07BzOhAcsa1xr Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 22-05-04 17:16:04, Baptiste Daroussin wrote: > On Wed, May 04, 2022 at 04:32:59PM +0200, Piotr Kubaj wrote: > > On 22-05-04 15:22:00, Emmanuel Vadot wrote: > > > On Wed, 4 May 2022 12:57:26 GMT > > > Piotr Kubaj wrote: > > >=20 > > > > The branch main has been updated by pkubaj: > > > >=20 > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3Decf09fe3460067b442= ba41a6adb85897c99442b5 > > > >=20 > > > > commit ecf09fe3460067b442ba41a6adb85897c99442b5 > > > > Author: Piotr Kubaj > > > > AuthorDate: 2022-05-04 12:54:19 +0000 > > > > Commit: Piotr Kubaj > > > > CommitDate: 2022-05-04 12:54:19 +0000 > > > >=20 > > > > graphics/gpu-firmware*-kmod: disable amdgpu on powerpc64 > > > > =20 > > > > amdgpu has known endianness issues and doesn't work on powerpc6= 4. > > > > radeonkms works, while amdgpu works on powerpc64le. > > > > --- > > > > graphics/gpu-firmware-amd-kmod/Makefile | 4 +- > > > > graphics/gpu-firmware-kmod/Makefile | 67 +++++++++++++++++----= ------------ > > > > 2 files changed, 37 insertions(+), 34 deletions(-) > > > >=20 > > >=20 > > > Can you respect MAINTAINER and open a review next time ? > >=20 > > I believe this falls under tier 2 blanket. Correct me if I'm mistaken. >=20 > It somehow is and somehow isn't, basically the blanket for tier 2 is to c= ommit > trivial changes which allows a port to work (or be flagged as not working= on a > given architecture) exactly the same as the "just fix it blanket". >=20 > Intrusive changes should anyway be discussed with the maintainer, and yes= it is > almost impossible to document what is intrusive from what is not, we have= to > rely on common sense here, and if one has a doubt, it is cheap to send a = mail, > open a PR, open a review to the maintainer anyway. >=20 > The change here does not "fix" anything, so in my opinion, seeking for re= view > and opening a discussion with the maintainer would have been a good idea. >=20 > As for whether your change is a good idea or not, I will let you discuss = that > with the maintainer. >=20 > Best regards, > Bapt OK, then if you want me to revert that commit, I can do it. Just note that graphics/gpu-firmware-kmod/Makefile already contained architecture conditional for intel. --=20 --Cnx07BzOhAcsa1xr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmJynAUACgkQelmbhSCD nJ1njw//eNLKsd2lfMKvjEEPVxzym0WXhZkX2ks8n5Yvpl5ENWcaO2VRRhLBXAJO x1wpttDPpI1IEDqSxWuLZTBvqKR0zZci0g1m97lGv7SkMLcUvL7gmvrQAtY2hbvW LYKP31qtr7MsmCKL2ZlxHhsbVV/6S4BVCh/pJJSKoaiW85hZsDE0N6Fylm2mbQoV lv0kkpqIAJFrDxrNCWUhqnGy/dS/KjpDttPefcg+rCbxvF5jwSYYlgCzSBBMoya4 tlC4iT0xeGMI090qwEotatvb+65EovCHJ+laErj/vtSEAuX8MxM39YcFuIW1F0pJ QZhEUJBN6uj823eR+uYcmUay7CyJbjXOyk9sCUpN0JIUempZUC0U0ir4NELg6WIs L/7EJTj+JQzOQWgfH7KYyGDs/3uRO6ZPIRY1roVe5GAzonho/tUu0Kp5m7soMkvF NPo5aeh+L//syhtwVKSNmfI8UiOaRrYeg0mtcUxoIhXe3gZv4jZMoy2At6rAoHft bulSw+vt7c+vKLFHqaFvg4EWzJh3UA+IY0O4uvbIwI4V2Vs6L79qiwmM001xPrlp +oRw2usdSsKGhJLQQYZzLNfJtekXX/VIkP5XzDorap1FKOzCKP5DkTp7oUf2pX+W cFM21DWtDT2poTQP8PjhcanCsBxGwKGpkaQ/LYdBjAzxhItqd9c= =3y/V -----END PGP SIGNATURE----- --Cnx07BzOhAcsa1xr--