From nobody Tue May 03 06:33:18 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 6CA621AC1558; Tue, 3 May 2022 06:33:23 +0000 (UTC) (envelope-from kp@krion.cc) Received: from krion.cc (krion.cc [148.251.235.209]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4KsqsZ5vd5z3LFh; Tue, 3 May 2022 06:33:22 +0000 (UTC) (envelope-from kp@krion.cc) Date: Tue, 3 May 2022 08:33:18 +0200 From: Kirill Ponomarev To: =?iso-8859-1?Q?Mika=EBl?= Urankar Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 15b1da831b7c - main - lang/sbcl: Add aarch64 support Message-ID: References: <202205030531.2435VnSg087811@gitrepo.freebsd.org> <2fb8edc2-66c6-9c38-a60a-c27170d6f2f2@FreeBSD.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kjaJNskJPBtCWyvz" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4KsqsZ5vd5z3LFh X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of kp@krion.cc designates 148.251.235.209 as permitted sender) smtp.mailfrom=kp@krion.cc X-Spamd-Result: default: False [-3.72 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.14)[-0.137]; FREEFALL_USER(0.00)[kp]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; R_SPF_ALLOW(-0.20)[+mx]; DMARC_NA(0.00)[krion.cc]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.18)[-0.184]; MLMMJ_DEST(0.00)[dev-commits-ports-all,dev-commits-ports-main]; SIGNED_PGP(-2.00)[]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:24940, ipnet:148.251.0.0/16, country:DE]; MID_RHS_MATCH_FROM(0.00)[] X-ThisMailContainsUnwantedMimeParts: N --kjaJNskJPBtCWyvz Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 05/03, Mika=EBl Urankar wrote: > On 03/05/2022 08:25, Kirill Ponomarev wrote: > > On 05/03, Mika=EBl Urankar wrote: > >> On 03/05/2022 08:02, Kirill Ponomarev wrote: > >>> Did you test it before you merged it? It seems tarballs in distinfo a= re > >>> missing. > >>> > >>> On 05/03, Mikael Urankar wrote: > >>>> The branch main has been updated by mikael: > >>>> > >>>> URL:https://cgit.FreeBSD.org/ports/commit/?id=3D15b1da831b7cbebe2762= fccebcfb3b0d50b27fc9 > >>>> > >>>> commit 15b1da831b7cbebe2762fccebcfb3b0d50b27fc9 > >>>> Author: Mikael Urankar > >>>> AuthorDate: 2022-04-04 11:00:54 +0000 > >>>> Commit: Mikael Urankar > >>>> CommitDate: 2022-05-03 05:22:17 +0000 > >>>> > >>>> lang/sbcl: Add aarch64 support > >>>> =20 > >>>> PR: 261096 > >>>> Reported by: Robert Clausecker > >>>> Approved by: krion (maintainer timeout) > >>>> --- > >>>> lang/sbcl/Makefile | 15 ++++++++++----- > >>>> 1 file changed, 10 insertions(+), 5 deletions(-) > >>>> > >>>> diff --git a/lang/sbcl/Makefile b/lang/sbcl/Makefile > >>>> index 5266d38ca984..b857d293f8f1 100644 > >>>> --- a/lang/sbcl/Makefile > >>>> +++ b/lang/sbcl/Makefile > >>>> @@ -18,7 +18,7 @@ LICENSE=3D BSD2CLAUSE PD > >>>> LICENSE_COMB=3D dual > >>>> LICENSE_FILE=3D ${WRKSRC}/COPYING > >>>> =20 > >>>> -ONLY_FOR_ARCHS=3D amd64 i386 > >>>> +ONLY_FOR_ARCHS=3D aarch64 amd64 i386 > >>>> =20 > >>>> LIB_DEPENDS=3D libgmp.so:math/gmp \ > >>>> libmpfr.so:math/mpfr > >>>> @@ -75,6 +75,8 @@ SAFEPOINT_VARS_OFF=3D MAKE_SH_ARGS+=3D"--without-s= b-safepoint --without-sb-thruption > >>>> SBCL_DISTFILES=3D ${PORTNAME}-${SBCL_BOOT_LIST:M${ARCHOS_PATTERN}= }-binary${EXTRACT_SUFX}:binaries > >>>> SBCL_VARS=3D XC_HOST=3D"${BOOT_WRKSRC}/src/runtime/sbcl --core ${= BOOT_WRKSRC}/output/sbcl.core --noinform --disable-debugger --no-sysinit --= no-userinit" > >>>> =20 > >>>> +XC_HOST=3D"ecl" > >>>> + > >>>> THREADS_VARS=3D MAKE_SH_ARGS+=3D"--with-sb-thread" > >>>> THREADS_VARS_OFF=3D MAKE_SH_ARGS+=3D"--without-sb-thread" > >>>> =20 > >>>> @@ -87,7 +89,10 @@ XREF_VARS_OFF=3D MAKE_SH_ARGS+=3D"--without-sb-xr= ef-for-internals" > >>>> ZLIB_VARS=3D MAKE_SH_ARGS+=3D"--with-sb-core-compression" > >>>> ZLIB_VARS_OFF=3D MAKE_SH_ARGS+=3D"--without-sb-core-compression" > >>>> =20 > >>>> -BOOTVERSION=3D 1.2.7 > >>>> +BOOTVERSION=3D ${BOOTVERSION_${ARCH}} > >>>> +BOOTVERSION_aarch64=3D 2.2.0 > >>>> +BOOTVERSION_i386=3D 1.2.7 > >>>> +BOOTVERSION_amd64=3D 1.2.7 > >>>> CONMODULES=3D asdf sb-aclrepl sb-bsd-sockets sb-cltl2 sb-concurre= ncy sb-cover \ > >>>> sb-executable sb-gmp sb-grovel sb-introspect sb-md5 sb-mpfr \ > >>>> sb-posix sb-queue sb-rotate-byte sb-rt sb-simple-streams \ > >>>> @@ -98,12 +103,12 @@ MAKE_SH_ARGS?=3D --prefix=3D"${PREFIX}" --xc-ho= st=3D"${XC_HOST}" > >>>> .if defined(DYNAMIC_SPACE_SIZE) > >>>> MAKE_SH_ARGS+=3D --dynamic-space-size=3D${DYNAMIC_SPACE_SIZE} > >>>> .endif > >>>> -SBCL_BOOT_LIST=3D ${BOOTVERSION}-x86-64-freebsd ${BOOTVERSION}-x86-= freebsd \ > >>>> - ${BOOTVERSION}-x86-64-dragonfly > >>>> +SBCL_BOOT_LIST=3D ${BOOTVERSION}-arm64-freebsd ${BOOTVERSION}-x86-6= 4-freebsd ${BOOTVERSION}-x86-freebsd \ > >>>> + ${BOOTVERSION}-x86-64-dragonfly \ > >>>> =20 > >>>> .include > >>>> =20 > >>>> -ARCHOS_PATTERN=3D *-${ARCH:S/amd64/x86-64/:S/i386/x86/}-${OPSYS:tl}* > >>>> +ARCHOS_PATTERN=3D *-${ARCH:S/aarch64/arm64/:S/amd64/x86-64/:S/i386/= x86/}-${OPSYS:tl}* > >>>> BOOT_WRKSRC=3D ${WRKDIR}/${PORTNAME}-${SBCL_BOOT_LIST:M${ARCHOS_P= ATTERN}} > >>>> =20 > >>>> .if ${PORT_OPTIONS:MLINKABLE_RUNTIME} > >> yes, I've done a poudriere testport before the commit on both aarch64 = and amd64. > >> The testport was successfull on both arch > >> I got a merged conflict and forgot to readd the distinfo for aarch64 > >> It's fixed in 1e4acb02a9bfdf003e20dd6627e2f49beeaa12e5 > > What I meant is did you test sbcl functionality on arm64, not building > > it on poudriere. >=20 > What do you mean? sbcl building itself is not a good test? No, not really. --kjaJNskJPBtCWyvz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEJCHRFhEAQujKni1pDyI9/LMCykUFAmJwzK4ACgkQDyI9/LMC ykUw8Qf/VExqxIxFg+ZmJm6cH8sL3mE17LO/PnjvG23MdvK5nsAmWAq8A3XGBDpf +HPPEjZ9X4f729Gup2SpkNAZZpRFLWKbAGMz/EVRgD9y75JMcaKiI47a2m9vO5NP UBRqJcPAp3hM5dZ8J7nV0bZAHelmSKo74dPFuz4kBAwjiaDy5aL9/NgNWmDQOyYU O39wlyzS8N4fjKUP1IcMWhLV3/pm16l8+4LQy9XiN4WgL+HA8A/w88c+pYNk5IoM JHe2sDdtqV7Yy+3D5aud1T3qAU763zyMy5BH3xooJZDOy1PY9Jrxda0F5i1TAPMM ujA/Q+bFudx26UhuMO/s43su9dC4rw== =tnjy -----END PGP SIGNATURE----- --kjaJNskJPBtCWyvz--