Re: git: 2b7653e70047 - main - x11-fm/polo: new port had been added (+)

From: Alexey Dokuchaev <danfe_at_freebsd.org>
Date: Sun, 27 Mar 2022 01:12:50 UTC 
On Sat, Mar 26, 2022 at 10:29:49AM -0300, Joseph Mingrone wrote:
> Is there a good reason to install the binaries unstripped?

No, can't think of one.

> > +-if (($gtk_minor == 14)) || (($gtk_minor == 16)) || (($gtk_minor == 18)) || (($gtk_minor == 20)) || (($gtk_minor == 22)); then
> > ++if [ $gtk_minor = 14 -o $gtk_minor = 16 -o $gtk_minor = 18 -o $gtk_minor = 20 -o $gtk_minor = 22 ]; then
> 
> [ .. ] || [ .. ] || .. is a better choice than -o within [ .. ].  See
> the BUGS section of TEST(1) and
> https://github.com/koalaman/shellcheck/wiki/SC2166.

Interesting.  Basically, it says "-a and -o are not well defined and can
cause incorrect results when arguments start with dashes or contain !".
Unfortunately it does not provide example of such breakage.  Personally
I like -o better than chainin of several test(1) calls, and since there
are definitely no dashes or !'s involved here we should be fine.

./danfe