From nobody Thu Mar 24 02:43:18 2022
X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id F29AC1A3BCA3;
	Thu, 24 Mar 2022 02:43:18 +0000 (UTC)
	(envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
	 client-signature RSA-PSS (4096 bits) client-digest SHA256)
	(Client CN "freefall.freebsd.org", Issuer "R3" (verified OK))
	by mx1.freebsd.org (Postfix) with ESMTPS id 4KP8fZ6Zhlz4hQ8;
	Thu, 24 Mar 2022 02:43:18 +0000 (UTC)
	(envelope-from danfe@freebsd.org)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim;
	t=1648089798;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=/VX7jMYsC1jqUZtSk7xnDK+xOCYfPfbTC0rQdpr2mTI=;
	b=Nhxvu+wILlttV5iJsv5Ypep+PYJaZoFvm3mDWJyTgxtLLmlS2AIY3WL6YHGS0tvEhERP9P
	xM6ENLMZFZraClhA1MWuLRnHUyMzmn7gznM3AqYpDdSU9DeOU6SMxla5ZbtuF7byzSHF8k
	rqxlU1jFaCo1troZfaWLqIFO6IRW/h1yLqA9WSTSSs9jCeRWhIbu4S9Ab7HISZOlWWiA8O
	YG32gr9BvLVvjYN1isblvKU4rALMxXqOTocDzHXh+0pRyy8JnfgYMDXSti3lNzYihlYf4v
	wtoS6bwyis/VWYVavvKLVzOdkLmkIwdi80OeDKn20f3B3/8MvQKoMmLDu1XKpQ==
Received: by freefall.freebsd.org (Postfix, from userid 1033)
	id D43075616; Thu, 24 Mar 2022 02:43:18 +0000 (UTC)
Date: Thu, 24 Mar 2022 02:43:18 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Neel Chauhan <nc@freebsd.org>
Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org,
	dev-commits-ports-main@freebsd.org
Subject: Re: git: 52bcb8cd9f26 - main - net/libgweather4: Don't use PORTSUFFIX
Message-ID: <YjvaxuJevGpjK8/o@FreeBSD.org>
References: <202203231752.22NHqbd3058172@gitrepo.freebsd.org>
List-Id: Commits to the main branch of the FreeBSD ports repository <dev-commits-ports-main.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main
List-Help: <mailto:dev-commits-ports-main+help@freebsd.org>
List-Post: <mailto:dev-commits-ports-main@freebsd.org>
List-Subscribe: <mailto:dev-commits-ports-main+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-ports-main+unsubscribe@freebsd.org>
Sender: owner-dev-commits-ports-main@freebsd.org
X-BeenThere: dev-commits-ports-main@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202203231752.22NHqbd3058172@gitrepo.freebsd.org>
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org;
	s=dkim; t=1648089798;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=/VX7jMYsC1jqUZtSk7xnDK+xOCYfPfbTC0rQdpr2mTI=;
	b=VSbzzr/PbjFDz5KOOTSSGvCtD4hTbW2NsAavtOnX47oSwqtmCILPrOfDg2SAV1VKaDwyXV
	k20YdtfRS+Q7E+jwLfSHTPm3tE4aZ97Ylqx+mg6dS8FsUMxkBViNZiYO5fOTLcwsR4KhCt
	EEqac1mrS8Fj952MK27XbL2CXqCsrF2O93m4Zjc+uyeFrQRlY2X6J20ptR5zhgVMP43xW1
	rIcE/EZdNudqJHZlMqDZE46fYx7hhwtw7ZXBgZr02iHcxCvmv2u8SqQSZP5n3/McXUtbS7
	3Zs9AomT/R18Y8JXihObqGTNwMFX4HJQ4KRhag8J9THGZ46RDdiE+7Ra2TpEEQ==
ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1648089798; a=rsa-sha256; cv=none;
	b=UszqCkHYkleKZb3xgxdoub7N5JFiU2W51CmWxPo1QjkjFS/kJpKObKz+SEDAeSdATGWUlu
	/9cGB0143Wkj8/Cc5XYv8JQl+DIyI7KvSmk5LXWdm5rQC2rUx6bnW/H890IUuM85XIidsa
	yTZ1EzVSjPn/Tct/nxTNHLov5tfZZ9XGk8JjNQWID9GliNfOM6piuNSaOOcw0n8dfNRydu
	nNeYmL+cMTU/E3SBnaxZ6lhyF+4/CXLiVreET2JTnuQeipfTKmalALzoS38Zi9ZRb6tHx/
	+g9Hl2neSQnlN5dhVwX+5ZQDWX5ljUUujMIC+r9sdUfGwhAGJF2t/SmVfSH4Ig==
ARC-Authentication-Results: i=1;
	mx1.freebsd.org;
	none
X-ThisMailContainsUnwantedMimeParts: N

On Wed, Mar 23, 2022 at 05:52:37PM +0000, Neel Chauhan wrote:
> commit 52bcb8cd9f26bc2f49bdeb4c1cbe5b3c64342fbf
> 
>     net/libgweather4: Don't use PORTSUFFIX

Why???

> @@ -1,10 +1,10 @@
> -PORTNAME=	libgweather
> +PORTNAME=	libgweather4
>  PORTVERSION=	4.0.0
>  CATEGORIES=	net gnome
>  MASTER_SITES=	GNOME
> -MASTER_SITE_SUBDIR=	sources/${PORTNAME}/${PORTVERSION:R}
> +MASTER_SITE_SUBDIR=	sources/libgweather/${PORTVERSION:R}
> +DISTNAME=	libgweather-${PORTVERSION}
>  DIST_SUBDIR=	gnome
> -PORTSUFFIX=	4

It was correct before, this is pretty standard way of how we keep and
annotate multi-version ports in the tree, embedding version in the
PORTNAME is wrong.  Please revert.

./danfe