Re: git: 53aec4c8cab1 - main - databases/tarantool: Depend on a specific version of devel/msgpuck.

Hi,

On Fri, Jun 10, 2022 at 8:39 PM Gleb Popov <arrowd@freebsd.org> wrote:

> The branch main has been updated by arrowd:
>
> URL:
> https://cgit.FreeBSD.org/ports/commit/?id=53aec4c8cab1306efeabf80d6841953515d3be57
>
> commit 53aec4c8cab1306efeabf80d6841953515d3be57
> Author:     Pavel Balaev <balaev@tarantool.org>
> AuthorDate: 2022-06-10 12:38:15 +0000
> Commit:     Gleb Popov <arrowd@FreeBSD.org>
> CommitDate: 2022-06-10 12:38:15 +0000
>
>     databases/tarantool: Depend on a specific version of devel/msgpuck.
>
>     The last msgpuck release introduced an ABI change, but did not bump
> .so version.
> ---
>  databases/tarantool/Makefile | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/databases/tarantool/Makefile b/databases/tarantool/Makefile
> index 05f808fb8ae0..d2263ad82338 100644
> --- a/databases/tarantool/Makefile
> +++ b/databases/tarantool/Makefile
> @@ -2,6 +2,7 @@
>
>  PORTNAME=      tarantool
>  PORTVERSION=   2.10.0
> +PORTREVISION=  1
>  CATEGORIES=    databases
>  MASTER_SITES=  https://download.tarantool.org/tarantool/src/
>
> @@ -16,12 +17,13 @@ BROKEN_riscv64=             fails to compile:
> mmintrin.h:50:12: invalid conversion between
>  NOT_FOR_ARCHS=         armv6 powerpc64 sparc64
>  NOT_FOR_ARCHS_REASON=  fails to build: Unsupported architecture
>
> -BUILD_DEPENDS= gsed:textproc/gsed
> +BUILD_DEPENDS= gsed:textproc/gsed \
> +               ${RUN_DEPENDS}
>  LIB_DEPENDS=   libcurl.so:ftp/curl \
>                 libicui18n.so:devel/icu \
> -               libmsgpuck.so:devel/msgpuck \
>                 libyaml.so:textproc/libyaml \
>                 libzstd.so:archivers/zstd
> +RUN_DEPENDS=   msgpuck>=2.0_4:devel/msgpuck
>

Thanks for adding the check but I would do it in a different way.
The simplest solution is to add "msgpuck>=2.0_4:devel/msgpuck" to
BUILD_DEPENDS.
Besides, since tarantool link against libmsgpuck.so, it is better to use
LIB_DEPENDS instead of BUILD_DEPENDS+RUN_DEPENDS.

Regards,
sunpoet