Re: git: 7ca4bf132765 - main - devel/ncurses: Do not strip libraries when DEBUG option is set

From: Baptiste Daroussin <bapt_at_FreeBSD.org>
Date: Thu, 02 Jun 2022 13:38:01 UTC 
On Thu, Jun 02, 2022 at 10:21:53AM +0000, Ganael LAPLANCHE wrote:
> The branch main has been updated by martymac:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=7ca4bf13276577544841a58c208e9b3fd7230b9a
> 
> commit 7ca4bf13276577544841a58c208e9b3fd7230b9a
> Author:     Ganael LAPLANCHE <martymac@FreeBSD.org>
> AuthorDate: 2022-06-02 10:20:03 +0000
> Commit:     Ganael LAPLANCHE <martymac@FreeBSD.org>
> CommitDate: 2022-06-02 10:20:03 +0000
> 
>     devel/ncurses: Do not strip libraries when DEBUG option is set
>     
>     Approved by:    blanket (simple fix)
> ---
>  devel/ncurses/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/devel/ncurses/Makefile b/devel/ncurses/Makefile
> index 31f487e0980a..463448b1d6b3 100644
> --- a/devel/ncurses/Makefile
> +++ b/devel/ncurses/Makefile
> @@ -95,7 +95,9 @@ post-install:
>  	${RM} ${STAGEDIR}${PREFIX}/lib/libncurses.so
>  	${ECHO} "INPUT(libncurses.so.${PORTVERSION:R} AS_NEEDED(-ltinfo))" > ${STAGEDIR}${PREFIX}/lib/libncurses.so
>  
> +.if ! ${PORT_OPTIONS:MDEBUG}
>  	${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/*.so.${DISTVERSION}
> +.endif

First the debug option should exist in the first place here,

second when WITH_DEBUG is set, then STRIP_CMD is set to /usr/bin/true so the if
it not useful.

Best regards,
Bapt